From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [RFC] elf: Implement filtering of symbols historically defined in libpthread
Date: Tue, 04 May 2021 14:33:46 +0200 [thread overview]
Message-ID: <87sg32k79x.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrryDZKxyr05EYjUgn4-wu_Ndu8wZZZVMGow4PU9+_TOA@mail.gmail.com> (H. J. Lu's message of "Tue, 4 May 2021 05:30:03 -0700")
* H. J. Lu:
> On Tue, May 4, 2021 at 5:27 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> >> The patch attempts to detect old main programs by looking for the
>> >> GLIBC_2.34 symbol version. Since we added __libc_start_main@@GLIBC_2.34
>> >> (which is called from our version of _start), all standard main programs
>> >> linked with glibc 2.34 or later will have this symbol version.
>>
>> > Can we invent a symbol or version to detect the older binaries?
>> > If not, can GNU property, ABI note, .... help here?
>>
>> I think we have all we need due to __libc_start_main@@GLIBC_2.34. It
>> was an unrelated change, but it helps here as well.
>
> So your patch isn't required? Can you add some tests to verify it?
No, the patch uses the absence of GLIBC_2.34 for detecting old binaries.
We cannot use symbol versions in other ways because one key
characteristic of weak references and underlinking is the lack of
version information on the symbol itself.
Thanks,
Florian
next prev parent reply other threads:[~2021-05-04 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 18:01 Florian Weimer
2021-05-04 6:55 ` Florian Weimer
2021-05-04 11:47 ` H.J. Lu
2021-05-04 12:04 ` Florian Weimer
2021-05-04 12:24 ` H.J. Lu
2021-05-04 12:27 ` Florian Weimer
2021-05-04 12:30 ` H.J. Lu
2021-05-04 12:33 ` Florian Weimer [this message]
2021-05-04 12:36 ` H.J. Lu
2021-05-04 12:43 ` Florian Weimer
2021-05-04 13:06 ` H.J. Lu
2021-05-04 13:13 ` Florian Weimer
2021-05-04 13:28 ` H.J. Lu
2021-05-04 12:59 ` Adhemerval Zanella
2021-05-04 21:08 ` Carlos O'Donell
2021-05-04 13:08 ` Andreas Schwab
2021-05-04 16:52 ` Florian Weimer
2021-05-04 21:28 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg32k79x.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).