From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 448E0385803D for ; Fri, 30 Apr 2021 04:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 448E0385803D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-tTiLq6JPM-ytK_KVamoCAA-1; Fri, 30 Apr 2021 00:52:32 -0400 X-MC-Unique: tTiLq6JPM-ytK_KVamoCAA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C927C1898297; Fri, 30 Apr 2021 04:52:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-124.ams2.redhat.com [10.36.115.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE0191962E; Fri, 30 Apr 2021 04:52:29 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Cc: tuliom@linux.ibm.com, anton@ozlabs.org, msc@linux.ibm.com, lamm@linux.ibm.com, rzinsly@linux.ibm.com Subject: Re: [PATCH v2] powerpc64le: Optimize memset for POWER10 References: <20210429234542.aeer5ncryowx34gs@work-tp> Date: Fri, 30 Apr 2021 06:52:42 +0200 In-Reply-To: <20210429234542.aeer5ncryowx34gs@work-tp> (Raoni Fassina Firmino via Libc-alpha's message of "Thu, 29 Apr 2021 20:45:42 -0300") Message-ID: <87sg38cr1h.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 04:52:38 -0000 * Raoni Fassina Firmino via Libc-alpha: > +L(dcbz_loop): > + /* Sets 512 bytes to zero in each iteration, the loop unrolling shows > + a throughput boost for large sizes (2048 bytes or higher). */ > + dcbz 0,r6 > + dcbz r9,r6 > + dcbz r10,r6 > + dcbz r11,r6 > + addi r6,r6,512 > + bdnz L(dcbz_loop) > +# ifdef __LITTLE_ENDIAN__ > + (hwcap2 & (PPC_FEATURE2_ARCH_3_1 | PPC_FEATURE2_HAS_ISEL) > + && hwcap & PPC_FEATURE_HAS_VSX) > + ? __memset_power10 : > +# endif Should the IFUNC resolver check that the cache line size is 128 bytes? Thanks, Florian