From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 42063383301D for ; Thu, 22 Apr 2021 07:58:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 42063383301D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-AZPuYQsTOI66UawkMyQNZQ-1; Thu, 22 Apr 2021 03:58:41 -0400 X-MC-Unique: AZPuYQsTOI66UawkMyQNZQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A74BB64149; Thu, 22 Apr 2021 07:58:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-20.ams2.redhat.com [10.36.113.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCD9E6064B; Thu, 22 Apr 2021 07:58:39 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: Florian Weimer via Libc-alpha Subject: Re: [PATCH v4 00/37] libpthread: Remove NPTL forwarders References: <878s5boo48.fsf@oldenburg.str.redhat.com> <20210422073542.GF9028@arm.com> Date: Thu, 22 Apr 2021 09:58:57 +0200 In-Reply-To: <20210422073542.GF9028@arm.com> (Szabolcs Nagy's message of "Thu, 22 Apr 2021 08:35:43 +0100") Message-ID: <87sg3ikawu.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 07:58:45 -0000 * Szabolcs Nagy: > The 04/21/2021 13:47, Florian Weimer via Libc-alpha wrote: >> * Florian Weimer via Libc-alpha: >> >> > I was on pseudo-vacation for a while and then some urgent downstream >> > work came up. Sorry. I hope to return to libpthread work part-time >> > next week, and full time after that. Hopefully this will get us back on >> > track. >> > >> > I believe this series addresses all of Adhemerval's review comments. It >> > switches to OTHER_SHLIB_COMPAT. I've retested this on i686-linux-gnu >> > and x86_64-linux-gnu, and built the entire thing with >> > build-many-glibcs.py. >> >> What's the next step for this series? Should I push it? > > on arm buildbot i see build failure: > > a - posix/getresuid/tmp/ccg97Xth.s: Assembler messages: > /tmp/ccg97Xth.s:210: Error: `__nptl_set_robust_list_avail' can't be equated to common symbol `__GI___nptl_set_robust_list_avail' > make[2]: *** [/work/glibc-armhf-linux/build/build/sysd-rules:161: /work/glibc-armhf-linux/build/build/elf/dl-tls_init_tp.os] Error 1 > .o Sorry, I didn't try building with GCC before 10 on these architectures. Please try the patch below. Thanks, Florian nptl: __nptl_set_robust_list_avail must be nocommon This is required for GCC versions before 10 which default to -fcommon. Fixes commit 442e8a40da9dfa24aeebf4f1a163f0a58b12cf7e ("nptl: Move part of TCB initialization from libpthread to __tls_init_tp"). diff --git a/sysdeps/nptl/dl-tls_init_tp.c b/sysdeps/nptl/dl-tls_init_tp.c index c5172b7613..05d2b6cfcc 100644 --- a/sysdeps/nptl/dl-tls_init_tp.c +++ b/sysdeps/nptl/dl-tls_init_tp.c @@ -23,7 +23,7 @@ #include #ifndef __ASSUME_SET_ROBUST_LIST -bool __nptl_set_robust_list_avail; +bool __nptl_set_robust_list_avail __attribute__ ((nocommon)); rtld_hidden_data_def (__nptl_set_robust_list_avail) #endif