public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo
Date: Mon, 22 Feb 2021 11:04:58 +0100	[thread overview]
Message-ID: <87sg5o7705.fsf@oldenburg.str.redhat.com> (raw)

Current kernels do not report this feature bit, so the test fails
if the hardware supports it.

According to

  [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors
  <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html>

some AMD processors set this CPUID bit.

---
 sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
index 75e7eb9352..a6a873b59c 100644
--- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
+++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
@@ -153,7 +153,10 @@ do_test (int argc, char **argv)
   fails += CHECK_PROC (fma4, FMA4);
   fails += CHECK_PROC (fpu, FPU);
   fails += CHECK_PROC (fsgsbase, FSGSBASE);
+#if 0
+  /* NB: /proc/cpuinfo doesn't report this feature.  */
   fails += CHECK_PROC (fsrm, FSRM);
+#endif
   fails += CHECK_PROC (fxsr, FXSR);
   fails += CHECK_PROC (gfni, GFNI);
   fails += CHECK_PROC (hle, HLE);


             reply	other threads:[~2021-02-22 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 10:04 Florian Weimer [this message]
2021-02-22 13:09 ` H.J. Lu
2021-02-22 13:15   ` Florian Weimer
2021-02-22 13:21     ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg5o7705.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).