* [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo
@ 2021-02-22 10:04 Florian Weimer
2021-02-22 13:09 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2021-02-22 10:04 UTC (permalink / raw)
To: libc-alpha
Current kernels do not report this feature bit, so the test fails
if the hardware supports it.
According to
[PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors
<https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html>
some AMD processors set this CPUID bit.
---
sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
index 75e7eb9352..a6a873b59c 100644
--- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
+++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
@@ -153,7 +153,10 @@ do_test (int argc, char **argv)
fails += CHECK_PROC (fma4, FMA4);
fails += CHECK_PROC (fpu, FPU);
fails += CHECK_PROC (fsgsbase, FSGSBASE);
+#if 0
+ /* NB: /proc/cpuinfo doesn't report this feature. */
fails += CHECK_PROC (fsrm, FSRM);
+#endif
fails += CHECK_PROC (fxsr, FXSR);
fails += CHECK_PROC (gfni, GFNI);
fails += CHECK_PROC (hle, HLE);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo
2021-02-22 10:04 [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo Florian Weimer
@ 2021-02-22 13:09 ` H.J. Lu
2021-02-22 13:15 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2021-02-22 13:09 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Current kernels do not report this feature bit, so the test fails
> if the hardware supports it.
>
> According to
>
> [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors
> <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html>
>
> some AMD processors set this CPUID bit.
>
> ---
> sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> index 75e7eb9352..a6a873b59c 100644
> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> @@ -153,7 +153,10 @@ do_test (int argc, char **argv)
> fails += CHECK_PROC (fma4, FMA4);
> fails += CHECK_PROC (fpu, FPU);
> fails += CHECK_PROC (fsgsbase, FSGSBASE);
> +#if 0
> + /* NB: /proc/cpuinfo doesn't report this feature. */
> fails += CHECK_PROC (fsrm, FSRM);
> +#endif
> fails += CHECK_PROC (fxsr, FXSR);
> fails += CHECK_PROC (gfni, GFNI);
> fails += CHECK_PROC (hle, HLE);
>
Since kernel does report it on Intel CPUs, please change it to
/* NB: /proc/cpuinfo reports this feature on Intel CPUs. */
if (cpu_features->basic.kind == arch_kind_intel)
on top of
https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo
2021-02-22 13:09 ` H.J. Lu
@ 2021-02-22 13:15 ` Florian Weimer
2021-02-22 13:21 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2021-02-22 13:15 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
* H. J. Lu:
> On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> Current kernels do not report this feature bit, so the test fails
>> if the hardware supports it.
>>
>> According to
>>
>> [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors
>> <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html>
>>
>> some AMD processors set this CPUID bit.
>>
>> ---
>> sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
>> index 75e7eb9352..a6a873b59c 100644
>> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
>> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
>> @@ -153,7 +153,10 @@ do_test (int argc, char **argv)
>> fails += CHECK_PROC (fma4, FMA4);
>> fails += CHECK_PROC (fpu, FPU);
>> fails += CHECK_PROC (fsgsbase, FSGSBASE);
>> +#if 0
>> + /* NB: /proc/cpuinfo doesn't report this feature. */
>> fails += CHECK_PROC (fsrm, FSRM);
>> +#endif
>> fails += CHECK_PROC (fxsr, FXSR);
>> fails += CHECK_PROC (gfni, GFNI);
>> fails += CHECK_PROC (hle, HLE);
>>
>
> Since kernel does report it on Intel CPUs, please change it to
>
> /* NB: /proc/cpuinfo reports this feature on Intel CPUs. */
> if (cpu_features->basic.kind == arch_kind_intel)
>
> on top of
>
> https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html
Oh, it looks like that kernel support has only been added in Linux 5.6.
Does this mean that tst-cpu-features-cpuinfo.c needs to check kernel
versions?
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo
2021-02-22 13:15 ` Florian Weimer
@ 2021-02-22 13:21 ` H.J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2021-02-22 13:21 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Mon, Feb 22, 2021 at 5:15 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > On Mon, Feb 22, 2021 at 2:17 AM Florian Weimer via Libc-alpha
> > <libc-alpha@sourceware.org> wrote:
> >>
> >> Current kernels do not report this feature bit, so the test fails
> >> if the hardware supports it.
> >>
> >> According to
> >>
> >> [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors
> >> <https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03370.html>
> >>
> >> some AMD processors set this CPUID bit.
> >>
> >> ---
> >> sysdeps/x86/tst-cpu-features-cpuinfo.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/sysdeps/x86/tst-cpu-features-cpuinfo.c b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> >> index 75e7eb9352..a6a873b59c 100644
> >> --- a/sysdeps/x86/tst-cpu-features-cpuinfo.c
> >> +++ b/sysdeps/x86/tst-cpu-features-cpuinfo.c
> >> @@ -153,7 +153,10 @@ do_test (int argc, char **argv)
> >> fails += CHECK_PROC (fma4, FMA4);
> >> fails += CHECK_PROC (fpu, FPU);
> >> fails += CHECK_PROC (fsgsbase, FSGSBASE);
> >> +#if 0
> >> + /* NB: /proc/cpuinfo doesn't report this feature. */
> >> fails += CHECK_PROC (fsrm, FSRM);
> >> +#endif
> >> fails += CHECK_PROC (fxsr, FXSR);
> >> fails += CHECK_PROC (gfni, GFNI);
> >> fails += CHECK_PROC (hle, HLE);
> >>
> >
> > Since kernel does report it on Intel CPUs, please change it to
> >
> > /* NB: /proc/cpuinfo reports this feature on Intel CPUs. */
> > if (cpu_features->basic.kind == arch_kind_intel)
> >
> > on top of
> >
> > https://sourceware.org/pipermail/libc-alpha/2021-January/122171.html
>
> Oh, it looks like that kernel support has only been added in Linux 5.6.
> Does this mean that tst-cpu-features-cpuinfo.c needs to check kernel
> versions?
Good idea. BTW, we are checking GCC versions for __builtin_cpu_supports.
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 10:04 [PATCH] x86: Do not check FSRM in tst-cpu-features-cpuinfo Florian Weimer
2021-02-22 13:09 ` H.J. Lu
2021-02-22 13:15 ` Florian Weimer
2021-02-22 13:21 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).