From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B2D913854817 for ; Mon, 25 Jan 2021 15:20:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B2D913854817 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10PF3X5r116261; Mon, 25 Jan 2021 10:20:06 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 369vg2pkss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 10:20:05 -0500 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 10PF3YkZ116299; Mon, 25 Jan 2021 10:20:05 -0500 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 369vg2pks6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 10:20:04 -0500 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10PFH14S001637; Mon, 25 Jan 2021 15:20:04 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma04wdc.us.ibm.com with ESMTP id 369wxp92re-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 15:20:04 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10PFK3YP17957350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Jan 2021 15:20:03 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1ED64BE054; Mon, 25 Jan 2021 15:20:03 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA16EBE053; Mon, 25 Jan 2021 15:20:02 +0000 (GMT) Received: from linux.ibm.com (unknown [9.160.62.145]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 25 Jan 2021 15:20:02 +0000 (GMT) From: Tulio Magno Quites Machado Filho To: libc-alpha@sourceware.org, Adhemerval Zanella Cc: Andreas Schwab , amodra@gmail.com Subject: Re: [PATCHv2] powerpc64: Implement TLS using PC-relative addressing In-Reply-To: <20210122012931.1354527-1-tuliom@linux.ibm.com> References: <87r1qi2ubi.fsf@igel.home> <20210122012931.1354527-1-tuliom@linux.ibm.com> User-Agent: Notmuch/0.31.3 (http://notmuchmail.org) Emacs/27.1 (x86_64-redhat-linux-gnu) Date: Mon, 25 Jan 2021 12:20:01 -0300 Message-ID: <87sg6p59i6.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-25_05:2021-01-25, 2021-01-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101250088 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 15:20:11 -0000 Tulio Magno Quites Machado Filho via Libc-alpha writes: > Changes since v1: > - Dropped the workaround for early GCC 10 versions. We can't get this > code to work without having the macro __PCREL__. The previous code > was failing if -mcpu=power10 -mno-pcrel was used. > - Fixed coding style issues (added space after #defined and removed > unnecessary parenthesis). > > ---8<--- > > As the TOC pointer becomes optional on POWER, TLS access has to be > modified in order to use PC-relative addressing instead of depending on > the TOC pointer availability. > > This patch also changes old TLS code to use the new syntax. It's a > purely aesthetical change: the old code still works and the new syntax > helps to move the argument setup instruction away from the call, which > is not used in an inline assembly. > > Suggested-by: Alan Modra Adhemerval, I've just realized I forgot to Cc you in this patch. It's fixing test failures when building glibc using --with-cpu=power10. May we merge it for 2.33? -- Tulio Magno