From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 401EE3894C35 for ; Wed, 23 Sep 2020 11:56:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 401EE3894C35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-Gky7cWZjOo-Vt1u-NJLn9w-1; Wed, 23 Sep 2020 07:56:04 -0400 X-MC-Unique: Gky7cWZjOo-Vt1u-NJLn9w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E2236415D; Wed, 23 Sep 2020 11:56:03 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-108.ams2.redhat.com [10.36.114.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57CF07368B; Wed, 23 Sep 2020 11:56:02 +0000 (UTC) From: Florian Weimer To: Efraim Flashner Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] posix: Don't automatically fail if _LIBC_REENTRANT isn't defined. References: <20200923105126.13566-1-efraim@flashner.co.il> Date: Wed, 23 Sep 2020 13:56:00 +0200 In-Reply-To: <20200923105126.13566-1-efraim@flashner.co.il> (Efraim Flashner's message of "Wed, 23 Sep 2020 13:51:26 +0300") Message-ID: <87sgb8r9kf.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 11:56:08 -0000 * Efraim Flashner: > diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c > index a03f478fc7..19d07d2581 100644 > --- a/sysdeps/posix/system.c > +++ b/sysdeps/posix/system.c > @@ -101,7 +101,7 @@ cancel_handler (void *arg) > static int > do_system (const char *line) > { > - int status = -1; > + int status = 0; > int ret; > pid_t pid; > struct sigaction sa; I don't think this is correct. You are just hiding an error return from posix_spawn, I think. A test case (against unpatched glibc) would help to clarify what you are looking for. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill