From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 991E93858D35 for ; Mon, 27 Jul 2020 10:12:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 991E93858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-eL_VInBIM2C99gjMQhGCrA-1; Mon, 27 Jul 2020 06:12:40 -0400 X-MC-Unique: eL_VInBIM2C99gjMQhGCrA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3002A80183C; Mon, 27 Jul 2020 10:12:39 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2419C60FC2; Mon, 27 Jul 2020 10:12:34 +0000 (UTC) From: Florian Weimer To: Chung-Lin Tang Cc: Carlos O'Donell , Andreas Schwab , Catherine Moore , GNU C Library Subject: Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader References: <87a724uhtf.fsf@igel.home> <87tv0ct1vl.fsf@igel.home> <456fbddc-7915-19da-3ffe-e58b86ae7980@redhat.com> <1427b370-7400-afd0-16e8-55c1072db20e@mentor.com> <47d5d0a3-4e55-d915-8ced-6ad0c68d6aaf@codesourcery.com> Date: Mon, 27 Jul 2020 12:12:33 +0200 In-Reply-To: <47d5d0a3-4e55-d915-8ced-6ad0c68d6aaf@codesourcery.com> (Chung-Lin Tang's message of "Mon, 27 Jul 2020 18:00:21 +0800") Message-ID: <87sgdd1d2m.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 10:12:44 -0000 * Chung-Lin Tang: > I understand the need to support timeouts, but actually, because of > the nature of the ld.so sorting tests, where a lot of the action > happens before/after main(), making the testcase executables use > support/test-driver.c isn't really that meaningful. In terms of the > relations, you would need to wrap the entire ld.so into a testcase for > that to work. Agreed. I think having a test without that protection should be fine, if it indeed runs in a few seconds now. > Do we already have some support program that embeds > support/test-driver.c (like a testcase) and allows forking of a > generic program + command-line? That should allow running the entire > ld.so with a timeout I suppose. Another method would be to do > something in the generated shell script wrapper to implement a > timeout. Historically, we have used shell tests for that. Thanks, Florian