From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id DD9F5384404D for ; Mon, 27 Jul 2020 12:20:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD9F5384404D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-qmPqh6eYNfyhlNs8vU01ug-1; Mon, 27 Jul 2020 08:20:28 -0400 X-MC-Unique: qmPqh6eYNfyhlNs8vU01ug-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A17580BCBA; Mon, 27 Jul 2020 12:20:27 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9120726AB; Mon, 27 Jul 2020 12:20:22 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: "Carlos O'Donell via Libc-alpha" , "Carlos O'Donell" Subject: Re: [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248] References: <20200716112651.2257283-1-hjl.tools@gmail.com> <87o8ofy8e7.fsf@oldenburg2.str.redhat.com> <56cafa21-37ea-b39e-8c84-afb258f0d17a@redhat.com> <87sgdqp434.fsf@oldenburg2.str.redhat.com> <180ab9db-d012-52c9-736f-437eecafc35b@redhat.com> <91e0af7e-5f5c-a994-d7bf-dd94c45dcd71@redhat.com> <6276e59d-a363-32a8-10b1-5e19dc065d6d@redhat.com> <6396e998-af22-deaf-3127-257059f9f46b@redhat.com> <87y2n54hv4.fsf@oldenburg2.str.redhat.com> Date: Mon, 27 Jul 2020 14:20:20 +0200 In-Reply-To: (H. J. Lu's message of "Mon, 27 Jul 2020 04:55:25 -0700") Message-ID: <87sgddup2z.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 12:20:31 -0000 * H. J. Lu: > On Sun, Jul 26, 2020 at 11:00 PM Florian Weimer wrote: >> >> * Carlos O'Donell via Libc-alpha: >> >> > We can't fix this easily quickly. >> >> We can make this test a non-container xtest today. It's better than no >> test at all. >> > > Currently this test is in sysdeps/unix/sysv/linux/x86_64/x32/tst-setgroups.c > since there are > > static int > do_test (void) > { > int size; > /* NB: Stack address is at 0xfffXXXXX. */ > gid_t list[NGROUPS_MAX]; > int status = EXIT_SUCCESS; > > and x32 stack starts at 0xfffXXXXX, which triggers this bug. Should > it be moved to nptl/tst-setgroups.c? Yes, this would make sense to me. Thanks, Florian