From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120])
 by sourceware.org (Postfix) with ESMTP id D9663386F831
 for <libc-alpha@sourceware.org>; Thu, 28 May 2020 12:58:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D9663386F831
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-176-l4GESUBlNaGHYRr7PT7H9A-1; Thu, 28 May 2020 08:58:17 -0400
X-MC-Unique: l4GESUBlNaGHYRr7PT7H9A-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4643B1855A2D;
 Thu, 28 May 2020 12:58:15 +0000 (UTC)
Received: from oldenburg2.str.redhat.com (ovpn-112-91.ams2.redhat.com
 [10.36.112.91])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 06B215D9EF;
 Thu, 28 May 2020 12:58:13 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Andreas Schwab <schwab@suse.de>,
 Alistair Francis <alistair.francis@wdc.com>,
 Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] Fix __clock_gettime64 with _ISOMAC in
 sysdeps/generic/hp-timing.h
References: <20200505181605.22346-1-lukma@denx.de>
 <CAMe9rOq1F4VoaSeh7eQ3S-xTE=8Hx0FacPbPimujn55867kWbQ@mail.gmail.com>
 <87v9kkmgcw.fsf@igel.home> <87367lk0nk.fsf@oldenburg2.str.redhat.com>
 <CAMe9rOoKZmyhkH4RU1R=GmzkufCHJN4BwHpk1AwZ+NbfkihMhw@mail.gmail.com>
 <87y2pdiltl.fsf@oldenburg2.str.redhat.com>
 <CAMe9rOrz6wDjeH=mBJuVJ4Ddvg_8pEyHUPjhOcGc_8zFbdXW0A@mail.gmail.com>
Date: Thu, 28 May 2020 14:58:12 +0200
In-Reply-To: <CAMe9rOrz6wDjeH=mBJuVJ4Ddvg_8pEyHUPjhOcGc_8zFbdXW0A@mail.gmail.com>
 (H. J. Lu via Libc-alpha's message of "Thu, 28 May 2020 05:28:30
 -0700")
Message-ID: <87sgfkb4ij.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2020 12:58:25 -0000

* H. J. Lu via Libc-alpha:

> diff --git a/sysdeps/generic/hp-timing.h b/sysdeps/generic/hp-timing.h
> index af9d92f7f7..99b12995f1 100644
> --- a/sysdeps/generic/hp-timing.h
> +++ b/sysdeps/generic/hp-timing.h
> @@ -24,6 +24,11 @@
>  #include <stdint.h>
>  #include <hp-timing-common.h>
>  
> +#ifdef _ISOMAC
> +# define __timespec64 timespec
> +# define __clock_gettime64 clock_gettime
> +#endif
> +
>  /* It should not be used for ld.so.  */
>  #define HP_TIMING_INLINE	(0)

To be honest, I would have expected different definitions of the timing
macros.  This redirection looks a bit iffy for me for _ISOMAC.

Thanks,
Florian