From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45877 invoked by alias); 9 Jul 2019 20:52:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 45868 invoked by uid 89); 9 Jul 2019 20:52:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1260, H*i:sk:xnbly3q, H*f:sk:xnbly3q X-HELO: mx1.redhat.com From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] test-in-container: Install locales into the test container References: Date: Tue, 09 Jul 2019 20:52:00 -0000 In-Reply-To: (DJ Delorie's message of "Tue, 09 Jul 2019 14:07:01 -0400") Message-ID: <87sgrfc4n5.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00198.txt.bz2 * DJ Delorie: > Florian Weimer writes: >> The testing time impact of this change is significant: It increases >> total test time from ~13 to ~15 minutes for me. However, I do not >> see any other way to run locale-dependent tests in a container. > > This is also the only way to auto-test "make install-locales" too :-) > >> $(MAKE) install DESTDIR=$(objpfx)testroot.pristine >> + $(MAKE) localedata/install-locales DESTDIR=$(objpfx)testroot.pristine >> touch $(objpfx)testroot.pristine/install.stamp > > This matches what's documented in INSTALL so LGTM. > > Reviewed-by: DJ Delorie The problem is that the delay also applies to partial runs of the test suite: $ time make -j8 subdirs=resolv check goes from: real 0m8.792s user 0m15.486s sys 0m6.017s to: real 2m5.588s user 13m20.667s sys 0m44.631s Compare this to the time of a clean glibc build on this machine: real 1m42.489s user 8m20.556s sys 2m6.281s This is a bit embarrassing because the pristine container constructed in this way is not even correct (bug 24794). I think applying this patch as-is would make glibc development substantially more difficult for me. Thanks, Florian