From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38011 invoked by alias); 21 Sep 2018 13:09:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 37305 invoked by uid 89); 21 Sep 2018 13:09:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sk:version X-HELO: mx1.redhat.com From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/3] posix: Add internal symbols for posix_spawn interface References: <20180915151622.17789-1-adhemerval.zanella@linaro.org> <5afa00e6-6152-c88e-66a1-d454d071fa96@redhat.com> Date: Fri, 21 Sep 2018 13:09:00 -0000 In-Reply-To: (Adhemerval Zanella's message of "Mon, 17 Sep 2018 12:10:12 -0700") Message-ID: <87sh23dmkt.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-09/txt/msg00400.txt.bz2 * Adhemerval Zanella: > On 17/09/2018 05:12, Florian Weimer wrote: >> On 09/15/2018 05:16 PM, Adhemerval Zanella wrote: >>> +__typeof (posix_spawn) __posix_spawn; >>> +libc_hidden_proto (__posix_spawn) >>=20 >> I think libc_hidden_proto without a GLIBC_PRIVATE export doesn't >> make much sense.=C2=A0 Why can't you use attribute_hidden here, like for >> the other new function symbols? >>=20 >> Thanks, >> Florian > > I had to use libc_hidden_proto because versioned_symbol with a hidden=20 > symbol produces only a local one: I see, I had forgotten about this. Thanks, Florian