From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: pc@us.ibm.com, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] powerpc: add sysconf support for cache geometries
Date: Fri, 09 Jun 2017 17:46:00 -0000 [thread overview]
Message-ID: <87shj9awaw.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <87zie22gdr.fsf@totoro.lan>
Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> writes:
> Paul Clarke <pc@us.ibm.com> writes:
>
>> There is currently no "cross-platform" (x86 and POWER) support for
>> determining the cacheline size.
>>
>> This patch adds support to sysconf() to correctly report cacheline sizes
>> based on the information in the auxilliary vector.
>>
>> Thus, using sysconf() is a cross-platform (x86 and POWER) solution for
>> determining cacheline sizes.
>>
>> Support is added (on powerpc) for:
>> _SC_LEVEL1_ICACHE_SIZE _SC_LEVEL1_ICACHE_ASSOC _SC_LEVEL1_ICACHE_LINESIZE
>> _SC_LEVEL1_DCACHE_SIZE _SC_LEVEL1_DCACHE_ASSOC _SC_LEVEL1_DCACHE_LINESIZE
>> _SC_LEVEL2_CACHE_SIZE _SC_LEVEL2_CACHE_ASSOC _SC_LEVEL2_CACHE_LINESIZE
>> _SC_LEVEL3_CACHE_SIZE _SC_LEVEL3_CACHE_ASSOC _SC_LEVEL3_CACHE_LINESIZE
>>
>> 2017-04-28 Paul A. Clarke <pc@us.ibm.com>
>>
>> * sysdeps/unix/sysv/linux/powerpc/sysconf.c: New file.
>> Add powerpc-specific overrides for L1, L2, L3 CACHE_SIZEs,
>> CACHE_ASSOCs, and CACHE_LINESIZEs, retrieving from auxv.
>> * sysdeps/unix/sysv/linux/powerpc/test-powerpc-linux-sysconf.c:
>> New file. Invoke newly supported sysconf values for powerpc,
>> and report results. If none are supported, report so.
>> * sysdeps/unix/sysv/linux/powerpc/Makefile (tests): Add new test,
>> tst-sysconf.
>
> The patch looks good except for a small issue.
>
> You need to bypass the PLT. The problem is that neither getauxval()
> nor __getauxval() provide this for you.
>
> I'm sending a patch to treat this.
Pushed with this fix as cdfbe5037f2f67bf5f560b73732b69d0fabe2314.
--
Tulio Magno
prev parent reply other threads:[~2017-06-09 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 19:15 Paul Clarke
2017-05-24 19:41 ` Tulio Magno Quites Machado Filho
2017-06-09 17:46 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shj9awaw.fsf@linux.vnet.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=pc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).