From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64302 invoked by alias); 21 Oct 2016 20:23:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 64289 invoked by uid 89); 21 Oct 2016 20:23:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: "Paul E. Murphy" , "libc-alpha\@sourceware.org" Cc: Subject: Re: [PATCH] powerpc: Cleanup fenv_private.h In-Reply-To: References: User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Fri, 21 Oct 2016 20:23:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102120-0032-0000-0000-0000029ED8C2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102120-0033-0000-0000-00000F17E495 Message-Id: <87shrpjvsj.fsf@totoro.br.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-21_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610210362 X-SW-Source: 2016-10/txt/msg00366.txt.bz2 "Paul E. Murphy" writes: > Tested on ppc64le, with results before and after. > > ---8<--- > Some of the masks are wrong, and the naming is confusing. > > There are two basic cases we really care about: > > 1. Stacking a new rounding mode when running certain > sections of code, and pausing exception handling. > > 2. Likewise, but discarding any exceptions which occur > while running under the new rounding mode. > > libc_feholdexcept_setround_ppc_ctx has been removed as it basically > does the same thing as libc_feholdsetround_ppc_ctx but also clearing > any sticky bits. The restore behavior is what differentiates these > two cases as the SET_RESTORE_ROUND{,_NOEX} macros will either merge > or discard all exceptions occurring during scope of their usage. > > Likewise, there are a number of routines to swap, replace, > or merge FP environments. This change reduces much of > the common and sometimes wrong code. LGTM. I'm pushing it. Thanks! -- Tulio Magno