From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DD8473858D1E for ; Tue, 14 May 2024 07:32:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD8473858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DD8473858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715671955; cv=none; b=AgHfhy11NHijrOHEt4cL8tWFarX57SxUCc4sJy2uP/KAjaHK5flHUPLAYRkmkpUG/aJ1BjbFSeQMh3KdTWkhLRgsSmLHDHv03a0f1cbsYwoyr3z+MryLEsjubaIq5QDGKoOFiGFAmokB/bhLah2MTyCcbfvUcAB8AO0lXY1dKCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715671955; c=relaxed/simple; bh=vBiWYfrOBLnC36hMto7czv5aA2iMxVfZd2vkSlVFCBY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=K7c+pibCcP1hkBNtTvwsWjfQlCq0v8e5oqcZFnTtnF+CPvpFEwi1t63da3Wyd8Mxwr6GURmBscOXcqFQkVZWgqUYRBbrYTuIr41jTh4krxQCCaoWJJz3K220qskDyxA2su49lVjlzb/UMbGXfB/csjFUoIId2tAiw9wuO8pIb8Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715671953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwaprPwoWTyHcYjhKhEAEpESg4KTAVuHPBmu5A07Ly8=; b=YqWxrAFpnQH3TXv1TPIiEXsZJo1u3ldpF9B4xuXJWs83zZCUH89OY65RmBm5FRSIgC2E/u iPIO6g1rMocUNSqeXqSRCUBGtUY9mG24kaw4e8Bbo3KiiL3uvYgPllHwQH2QbxdNnw6x5Z rKW4D3AeY77WSMKqLXcEJOrn7PYlHWo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-a0H83INUOJ-nCBS07psulw-1; Tue, 14 May 2024 03:32:31 -0400 X-MC-Unique: a0H83INUOJ-nCBS07psulw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94C953806702; Tue, 14 May 2024 07:32:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE8F021EE56B; Tue, 14 May 2024 07:32:30 +0000 (UTC) From: Florian Weimer To: Andrew Pinski Cc: Subject: Re: [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's 0ryon-1 core In-Reply-To: <20240508165924.874710-2-quic_apinski@quicinc.com> (Andrew Pinski's message of "Wed, 8 May 2024 09:59:24 -0700") References: <20240508165924.874710-1-quic_apinski@quicinc.com> <20240508165924.874710-2-quic_apinski@quicinc.com> Date: Tue, 14 May 2024 09:32:29 +0200 Message-ID: <87ttj0vofm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Andrew Pinski: > +L(try_zva): > +=09/* Write the first and last 64 byte aligned block using stp rather > +=09 than using DC ZVA. This is faster on some cores. > +=09 */ The =E2=80=9Csome cores=E2=80=9D part seems outdated if it's just a memset = for the Oryon-1 core (singulare). This comment and some others, for example > +=09/* > +=09 * Adjust count and bias for loop. By subtracting extra 1 from count, > +=09 * it is easy to use tbz instruction to check whether loop tailing > +=09 * count is less than 33 bytes, so as to bypass 2 unnecessary stps. > +=09 */ do not use GNU style. This one is GNU style: > +=09/* Set 64..96 bytes. Write 64 bytes from the start and > +=09 32 bytes from the end. */ No separate start end end lines, no * indentation, space after the final . Thanks, Florian