From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8FC943858D20 for ; Wed, 17 Apr 2024 17:04:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FC943858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FC943858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713373474; cv=none; b=Xwn3yP2BFxOsSlqaGPiN5ayI2bGMy/+XGF8foO+sjJYWYTcQelXQL0Zn6bk6YTeMYM7EY6HjX7HwDiC9EtFacJgRFKiAARXrhj0DUNSYex2m1r0FGgOu+JVlJyM8cog2dv1GpjUAYv4jBatqaGmEbXxdIW+2nx1ZvIYEq/aUZ1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713373474; c=relaxed/simple; bh=DGbfAaILxZSMKFemI3TFJbsXie/TOnnGA1SFomApA08=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=U1mp+9ITp0FI9t4/S9YqBeQnzXxO/cmh+ZHwq2CrrDYMaPStflqfrNHId7iwiBPrnzX5Vvmvr8cZA4K0nVeDzwOFdae3Wdk0FifBFHb89eTTjNSMZ1BxxCTgPp9oDFxFl0KNxhF/V3iXGlovj7qd8jXx00VWuDFQMtqgEDwamM4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713373469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dWiZdMfZVF75T5YuwWRP4sRB3U43DkZ7cwk7a510YB0=; b=cZHvLW0dTt+C5Ew0/n9gk6rLCOF1tDJLWB67O9VvkA4xkc1Byfls3eu5eueMlHx2QMTaWJ Oe3fnFHntryT+Ly2I1sShj2x80Kc6adZeFGQLlsWEjRWLWtQuKFdPAQGzrCOFCsDbtzjmS wchiXGZfZfiqMAvZuKgkDDN/+Q9e0A8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-sYMvIhyINMGt6XW-e_4Mog-1; Wed, 17 Apr 2024 13:04:25 -0400 X-MC-Unique: sYMvIhyINMGt6XW-e_4Mog-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 656BE1C0AF4C; Wed, 17 Apr 2024 17:04:24 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29C1C20368A4; Wed, 17 Apr 2024 17:04:22 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Bruno Haible , Adhemerval Zanella , libc-alpha@sourceware.org, Paul Eggert Subject: Re: [PATCH v5] posix: Sync tempname with gnulib In-Reply-To: (Andreas Schwab's message of "Wed, 17 Apr 2024 16:37:35 +0200") References: <20240410122009.784038-1-adhemerval.zanella@linaro.org> <12196437.mmXuBLWUr5@nimes> Date: Wed, 17 Apr 2024 19:04:17 +0200 Message-ID: <87ttjzgbu6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Andreas Schwab: > On Apr 17 2024, Bruno Haible wrote: > >> Andreas Schwab wrote: >>> > - while (unfair_min <= v); >>> v >= unfair_min >> >> Code written by Paul Eggert prefers use of the operators < and <=, >> rather than > and >=. It's a matter of style. Such questions of style >> are not worth introducing differences between gnulib and glibc. > > We cannot accept obfuscated code. We have higher standards. I also prefer to mention the fastest-changing variable first in comparisons. Thanks, Florian