public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,  DJ Delorie <dj@redhat.com>
Subject: Re: [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used
Date: Mon, 18 Mar 2024 12:58:50 +0100	[thread overview]
Message-ID: <87ttl3sqdh.fsf@oldenburg3.str.redhat.com> (raw)
In-Reply-To: <20240318114259.164673-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 18 Mar 2024 08:42:59 -0300")

* Adhemerval Zanella:

> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h
> index 4d38b8ba76..8fe811bd9e 100644
> --- a/sysdeps/generic/features-time64.h
> +++ b/sysdeps/generic/features-time64.h
> @@ -17,3 +17,7 @@
>     <https://www.gnu.org/licenses/>.  */
>  
>  /* The generic configuration only support _TIME_BITS=32.  */
> +#define __USE_TIME_BITS64       0
> +
> +/* The __USE_TIME64_REDIRECTS macro defines whether the 64 time_t
> +   redirects will be used for 64 bit aware symbols.  */

I thought that generic was going to be the future in terms of ABIs?  So
restricting it to _TIME_BITS=32 is surprising.

Thanks,
Florian


  reply	other threads:[~2024-03-18 11:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 11:42 Adhemerval Zanella
2024-03-18 11:58 ` Florian Weimer [this message]
2024-03-18 12:18   ` Adhemerval Zanella Netto
2024-03-18 12:07 ` Andreas Schwab
2024-03-18 12:19   ` Adhemerval Zanella Netto
2024-03-18 12:21 Adhemerval Zanella
2024-03-18 12:23 ` Adhemerval Zanella Netto
2024-03-18 12:37 ` Andreas Schwab
2024-03-18 12:53   ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttl3sqdh.fsf@oldenburg3.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).