From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BDCDA3858D28 for ; Tue, 14 Nov 2023 16:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDCDA3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDCDA3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699980209; cv=none; b=nt5b3VxTmvEAxewCV75jBvChTMrYLYslRnbBelQ2g1+NFuNEh6t1H9Y9E99c/ekoFez/zpbTonULXzZ4E5qQCnIDAZ04lqpzVe0Pw8ePNWd19bSpaNZj8g26q5w/xpZmBA9HZfbZHvubGVKwN9aBv9Sre7Ty8f6pWGlk7zRr3Ts= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699980209; c=relaxed/simple; bh=IPj1OzECdM3O1WrOZf2a5HIPEuLW4EK4Zv5PBUz3LeM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=f5AoazrFAgIy9LBN9v48vhDZlIEzay0kIRYqB2NlJSm/Eli1djaQvaGe8GSw7L2LD8PVt8TVthecbhXtDmwq/iS/mgraqFVFC+fqx3xRAnVAG6HWKsEaLfwOJse3ABpB6pGS8m1tXtTu6STOTN6hEm1PY+LjktQK3HdNVigbJQ4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699980208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7cok8Q3IObYPFL+9sXuypqM5Ca4C9SOJD0kAH42Df6o=; b=bDW8nbqokHf1PVSiOKBcDuMjvADas0g4YbEFaANCi4Fuwe/BfgktYSvhwPZosAyvOEzAe4 EHLn9Ow7Ft6CdGCuT6eiqN5XXq+fvNdChP2i416c3PVyxY6EhQXQO7EG45dMuJdmcTzh0E jApoZR/KCbmG7oGN+1Yjyvsf9KtF+S4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-KeUFTFdVMxGEvUF3WrroaQ-1; Tue, 14 Nov 2023 11:43:25 -0500 X-MC-Unique: KeUFTFdVMxGEvUF3WrroaQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 508C63827962; Tue, 14 Nov 2023 16:43:24 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 248331121307; Tue, 14 Nov 2023 16:43:21 +0000 (UTC) From: Florian Weimer To: Peter Zijlstra Cc: Xi Ruoyao , libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Thomas Gleixner , =?utf-8?Q?Andr=C3=A9?= Almeida Subject: Re: Several tst-robust* tests time out with recent Linux kernel References: <4bda9f2e06512e375e045f9e72edb205104af19c.camel@xry111.site> <20231114153100.GY8262@noisy.programming.kicks-ass.net> <20231114154017.GI4779@noisy.programming.kicks-ass.net> Date: Tue, 14 Nov 2023 17:43:20 +0100 In-Reply-To: <20231114154017.GI4779@noisy.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 14 Nov 2023 16:40:17 +0100") Message-ID: <87ttpowajb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Peter Zijlstra: >> diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h >> index b5379c0e6d6d..1a1f9301251f 100644 >> --- a/kernel/futex/futex.h >> +++ b/kernel/futex/futex.h >> @@ -17,7 +17,7 @@ >> * restarts. >> */ >> #ifdef CONFIG_MMU >> -# define FLAGS_SHARED 0x01 >> +# define FLAGS_SHARED 0x10 >> #else >> /* >> * NOMMU does not have per process address space. Let the compiler optimize > > Just the above seems sufficient. There are a few futex_wake calls which hard-code the flags argument as 1: kernel/futex/core.c=637=static int handle_futex_death(u32 __user *uaddr, struct task_struct *curr, -- kernel/futex/core.c-686- * this. kernel/futex/core.c-687- */ kernel/futex/core.c-688- owner = uval & FUTEX_TID_MASK; kernel/futex/core.c-689- kernel/futex/core.c-690- if (pending_op && !pi && !owner) { kernel/futex/core.c:691: futex_wake(uaddr, 1, 1, FUTEX_BITSET_MATCH_ANY); kernel/futex/core.c-692- return 0; kernel/futex/core.c-693- } kernel/futex/core.c-694- kernel/futex/core.c-695- if (owner != task_pid_vnr(curr)) kernel/futex/core.c-696- return 0; -- kernel/futex/core.c-739- /* kernel/futex/core.c-740- * Wake robust non-PI futexes here. The wakeup of kernel/futex/core.c-741- * PI futexes happens in exit_pi_state(): kernel/futex/core.c-742- */ kernel/futex/core.c-743- if (!pi && (uval & FUTEX_WAITERS)) kernel/futex/core.c:744: futex_wake(uaddr, 1, 1, FUTEX_BITSET_MATCH_ANY); kernel/futex/core.c-745- kernel/futex/core.c-746- return 0; kernel/futex/core.c-747-} kernel/futex/core.c-748- kernel/futex/core.c-749-/* Thanks, Florian