public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Stefan Liebler <stli@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] tst-spawn-cgroup.c: Fix argument order of UNSUPPORTED message.
Date: Thu, 19 Oct 2023 15:39:20 +0200	[thread overview]
Message-ID: <87ttqmrat3.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20231019123559.3922193-1-stli@linux.ibm.com> (Stefan Liebler's message of "Thu, 19 Oct 2023 14:35:59 +0200")

* Stefan Liebler:

> The arguments for "expected" and "got" are mismatched.  Furthermore
> this patch is dumping both values as hex.
> ---
>  sysdeps/unix/sysv/linux/tst-spawn-cgroup.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c b/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
> index 84e24696eb..a9843aeb89 100644
> --- a/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
> +++ b/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
> @@ -136,9 +136,9 @@ create_new_cgroup (char **newcgroup)
>      }
>  
>    if (!F_TYPE_EQUAL (fs.f_type, CGROUP2_SUPER_MAGIC))
> -    FAIL_UNSUPPORTED ("%s is not a cgroupv2 (expected %jx, got %jd)",
> -		      CGROUPFS, (intmax_t) fs.f_type,
> -		      (intmax_t) CGROUP2_SUPER_MAGIC);
> +    FAIL_UNSUPPORTED ("%s is not a cgroupv2 (expected 0x%jx, got 0x%jx)",
> +		      CGROUPFS, (intmax_t) CGROUP2_SUPER_MAGIC,
> +		      (intmax_t) fs.f_type);
>  
>    char *cgroup = get_cgroup ();
>    TEST_VERIFY_EXIT (cgroup != NULL);

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


      parent reply	other threads:[~2023-10-19 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 12:35 Stefan Liebler
2023-10-19 13:36 ` Adhemerval Zanella Netto
2023-10-20  6:48   ` Stefan Liebler
2023-10-19 13:39 ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttqmrat3.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=stli@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).