From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 18E993858C2D
 for <libc-alpha@sourceware.org>; Tue, 16 Aug 2022 09:51:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18E993858C2D
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-621-wvLoUBNyNx66auw_ofUgZg-1; Tue, 16 Aug 2022 05:51:13 -0400
X-MC-Unique: wvLoUBNyNx66auw_ofUgZg-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
 [10.11.54.7])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44315299E76E;
 Tue, 16 Aug 2022 09:51:13 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.98])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 80506140EBE3;
 Tue, 16 Aug 2022 09:51:12 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Linux: Fix enum fsconfig_command detection in
 <sys/mount.h>
References: <87a684ejbj.fsf@oldenburg.str.redhat.com> <mvmsflwh69p.fsf@suse.de>
Date: Tue, 16 Aug 2022 11:51:10 +0200
In-Reply-To: <mvmsflwh69p.fsf@suse.de> (Andreas Schwab's message of "Tue, 16
 Aug 2022 11:44:34 +0200")
Message-ID: <87tu6ccy9d.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2022 09:51:16 -0000

* Andreas Schwab:

> On Aug 16 2022, Florian Weimer via Libc-alpha wrote:
>
>> The #ifdef FSOPEN_CLOEXEC check did not work because the macro
>> was defined prior to its use.
>
> This is confusing, since generally we want macros to be defined before
> their use.  What's important here is that the use is about checking for
> absence of the macro in the kernel header.

Do you suggest to reword the commit message?  What about this?

=E2=80=9C
The #ifdef FSOPEN_CLOEXEC check did not work because the macro
was always defined in this header prior to the check, so that
the <linux/mount.h> contents did not matter.
=E2=80=9D

Thanks,
Florian