public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Fāng-ruì Sòng" <maskray@google.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Fix handling of symbol versions which hash to zero (bug 29190)
Date: Thu, 02 Jun 2022 10:25:29 +0200	[thread overview]
Message-ID: <87tu93zd3a.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAFP8O3KEake+Rzo9yT3CNYiZw+0G9HerT36=yr=koESYw4oiGQ@mail.gmail.com> (=?utf-8?B?IkbEgW5nLXJ1w6wgU8OybmciJ3M=?= message of "Wed, 1 Jun 2022 22:34:11 -0700")

* Fāng-ruì Sòng:

>> Should I send a v2 with these changes?
>
> If you drop   (*num_versions)++ == 0  , this can be committed as-is.
>
> Reviewed-by: Fangrui Song <maskray@google.com>

It doesn't work in the current code because

      /* If we have seen exactly one versioned symbol while we are
	 looking for an unversioned symbol and the version is not the
	 default version we still accept this symbol since there are
	 no possible ambiguities.  */
      sym = num_versions == 1 ? versioned_sym : NULL;

discards the found versioned_sym if num_versions is not incremented.

libio/tst-vtables-interposed and other tests fail as a result.

Thanks,
Florian


  reply	other threads:[~2022-06-02  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 11:15 Florian Weimer
2022-06-01  4:30 ` Fangrui Song
2022-06-01  7:28   ` Florian Weimer
2022-06-02  5:34     ` Fāng-ruì Sòng
2022-06-02  8:25       ` Florian Weimer [this message]
2022-06-04  3:15         ` Fāng-ruì Sòng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu93zd3a.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).