public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] dlfcn: Move RTLD_DEFAULT/RTLD_NEXT outside __USE_GNU
Date: Mon, 23 May 2022 17:21:22 +0200	[thread overview]
Message-ID: <87tu9gtgul.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220522193642.3598646-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Sun, 22 May 2022 12:36:42 -0700")

* Fangrui Song via Libc-alpha:

> RTLD_DEFAULT and RTLD_NEXT appear in IEEE Std 1003.1-2004.  (RTLD_NEXT
> even appears in the 1997 SUS version 2.)  Many systems (e.g. FreeBSD, musl)
> just define the two macros unconditionally.
>
> Let's do the same, as if the state before
> commit 70b2845f71c1fb6bd5ec3ef325974b6a90cdb45c.

Please de-indent the #defines for RTLD_NEXT and RTLD_DEFAULT because
they now unconditional.  No need to post a new version.

POSIX reserves the RTLD_ namespace, and this is already reflected in our
conform tests.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
Tested-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2022-05-23 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-22 19:36 Fangrui Song
2022-05-23 15:21 ` Florian Weimer [this message]
2022-05-23 15:42   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu9gtgul.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).