From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B20423857419 for ; Mon, 23 May 2022 15:21:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B20423857419 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-496-13OHIl0qO86ffQBxbdXjnQ-1; Mon, 23 May 2022 11:21:30 -0400 X-MC-Unique: 13OHIl0qO86ffQBxbdXjnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CABCD100BAAC; Mon, 23 May 2022 15:21:29 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3142EC27EA2; Mon, 23 May 2022 15:21:29 +0000 (UTC) From: Florian Weimer To: Fangrui Song via Libc-alpha Subject: Re: [PATCH] dlfcn: Move RTLD_DEFAULT/RTLD_NEXT outside __USE_GNU References: <20220522193642.3598646-1-maskray@google.com> Date: Mon, 23 May 2022 17:21:22 +0200 In-Reply-To: <20220522193642.3598646-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Sun, 22 May 2022 12:36:42 -0700") Message-ID: <87tu9gtgul.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2022 15:21:35 -0000 * Fangrui Song via Libc-alpha: > RTLD_DEFAULT and RTLD_NEXT appear in IEEE Std 1003.1-2004. (RTLD_NEXT > even appears in the 1997 SUS version 2.) Many systems (e.g. FreeBSD, musl) > just define the two macros unconditionally. > > Let's do the same, as if the state before > commit 70b2845f71c1fb6bd5ec3ef325974b6a90cdb45c. Please de-indent the #defines for RTLD_NEXT and RTLD_DEFAULT because they now unconditional. No need to post a new version. POSIX reserves the RTLD_ namespace, and this is already reflected in our conform tests. Reviewed-by: Florian Weimer Tested-by: Florian Weimer Thanks, Florian