public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5] elf: Sort tests and modules-names
Date: Tue, 04 Jan 2022 15:33:49 +0100	[thread overview]
Message-ID: <87tuej3702.fsf@igel.home> (raw)
In-Reply-To: <CAMe9rOp53ex=eeHfF4Ys9HHVZjyvOYXp2HafTzBfWUF1YZa1Rw@mail.gmail.com> (H. J. Lu's message of "Tue, 4 Jan 2022 06:01:31 -0800")

On Jan 04 2022, H.J. Lu wrote:

> On Tue, Jan 4, 2022 at 12:38 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Jan 03 2022, H.J. Lu via Libc-alpha wrote:
>>
>> > +tests-cxx = \
>> > +  tst-dlopen-nodelete-reloc \
>> > +  tst-nodelete \
>> > +  tst-unique3 \
>> > +  tst-unique4 \
>> > +
>>
>> > +  vismod1 \
>> > +  vismod2 \
>> > +  vismod3 \
>> > +
>>
>> > +  tst-unique3lib \
>> > +  tst-unique3lib2 \
>> > +  tst-unique4lib \
>> > +
>> > +modules-names += \
>> > +  $(if $(CXX),$(modules-names-cxx)) \
>> > +  $(modules-execstack-$(have-z-execstack)) \
>> > +  $(tst-tls-many-dynamic-modules) \
>> > +  $(tst-tls-many-dynamic-modules-dep) \
>> > +  $(tst-tls-many-dynamic-modules-dep-bad) \
>> > +  $(tlsmod17a-modules) \
>> > +  $(tlsmod18a-modules) \
>>
>>
>> Trailing backslashes are no good.
>
> It was added so that only one line is needed when appending
> to the list.

The blank lines can easily get lost.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2022-01-04 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 23:32 H.J. Lu
     [not found] ` <87zgob3nh1.fsf@igel.home>
2022-01-04 14:01   ` H.J. Lu
2022-01-04 14:33     ` Andreas Schwab [this message]
2022-01-04 14:36       ` Florian Weimer
2022-01-04 15:00         ` [PATCH] elf: Add a comment after trailing backslashes H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuej3702.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).