From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 25E0E385840D for ; Mon, 30 Aug 2021 09:25:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25E0E385840D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-mg1MD3dWP4GAhRChUyQ3eg-1; Mon, 30 Aug 2021 05:25:17 -0400 X-MC-Unique: mg1MD3dWP4GAhRChUyQ3eg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B77741853029; Mon, 30 Aug 2021 09:25:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFC8660BD9; Mon, 30 Aug 2021 09:25:15 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 09/19] nptl: Fix race between pthread_kill and thread exit (bug 12889) References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-10-adhemerval.zanella@linaro.org> <878s0o70ab.fsf@oldenburg.str.redhat.com> Date: Mon, 30 Aug 2021 11:25:13 +0200 In-Reply-To: (Adhemerval Zanella's message of "Thu, 26 Aug 2021 14:06:59 -0300") Message-ID: <87tuj7s2rq.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 09:25:20 -0000 * Adhemerval Zanella: >> This needs a comment explaining that *all* pending signals are delivered >> at the point of the __libc_signal_restore_set call. I hope that this is >> actually what happens in Linux; POSIX only guarantees that for one >> pending signal that is unblocked. > > My understanding from kernel/signal.c all pending signals are delivered > with the signal mask restore, but only real-time one are queued (and > subjected to RLIMIT_SIGPENDING, which causes another issue [1]). If real-time signals are special, I think we need to change the way we handle the self-signal case and avoid the lock there. Thanks, Florian