From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 405DA387549C for ; Mon, 5 Jul 2021 18:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 405DA387549C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-QDcoUX9MOgKdAulsspbDag-1; Mon, 05 Jul 2021 14:59:10 -0400 X-MC-Unique: QDcoUX9MOgKdAulsspbDag-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD059804301; Mon, 5 Jul 2021 18:59:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E302E5D6CF; Mon, 5 Jul 2021 18:59:08 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 2/7] linux: Consolidate Linux setsockopt implementation References: <20210705183027.3804093-1-adhemerval.zanella@linaro.org> <20210705183027.3804093-3-adhemerval.zanella@linaro.org> Date: Mon, 05 Jul 2021 20:59:06 +0200 In-Reply-To: <20210705183027.3804093-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 5 Jul 2021 15:30:22 -0300") Message-ID: <87tul8k2o5.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2021 18:59:13 -0000 * Adhemerval Zanella via Libc-alpha: > This patch consolidates the setsockopt implementation on > sysdeps/unix/sysv/linux/getsockopt.c. The changes are: > > 1. Remove it from auto-generation syscalls.list on all architectures. > > 2. Add __ASSUME_SETSOCKOPT_SYSCALL as default and undef if for > specific kernel versions on some architectures. > > This also fix a potential issue where 32-bit time_t ABI should use the > linux setsockopt which overrides the underlying SO_* constants used for > socket timestamping for _TIME_BITS=64. Looks okay to me as well. Thanks, Florian