From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 204F73835432 for ; Wed, 23 Jun 2021 19:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 204F73835432 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-_VWQIgfcMCO9fedpItO5SQ-1; Wed, 23 Jun 2021 15:59:32 -0400 X-MC-Unique: _VWQIgfcMCO9fedpItO5SQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25DEB800D62; Wed, 23 Jun 2021 19:59:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-211.ams2.redhat.com [10.36.112.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C64F19711; Wed, 23 Jun 2021 19:59:30 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 16/34] Linux: Move aio_suspend, aio_suspend64, __aio_suspend_time64 to libc References: <92036704851ce71f7b6acf248a01518739ac9ab4.1623956057.git.fweimer@redhat.com> <99f31cdf-8301-88dc-7f64-b0af292bfbcb@linaro.org> Date: Wed, 23 Jun 2021 21:59:28 +0200 In-Reply-To: <99f31cdf-8301-88dc-7f64-b0af292bfbcb@linaro.org> (Adhemerval Zanella's message of "Wed, 23 Jun 2021 16:52:52 -0300") Message-ID: <87tuloxsgv.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 19:59:35 -0000 * Adhemerval Zanella: >> - pthread_cleanup_push (cleanup, &clparam); >> +#if PTHREAD_IN_LIBC >> + __libc_cleanup_region_start (1, cleanup, &clparam); >> +#else >> + __pthread_cleanup_push (cleanup, &clparam); >> +#endif >> >> #ifdef DONT_NEED_AIO_MISC_COND >> result = do_aio_misc_wait (&cntr, timeout == NULL ? NULL : &ts); >> @@ -194,7 +200,11 @@ __aio_suspend_time64 (const struct aiocb *const list[], int nent, >> timeout == NULL ? NULL : &ts32); >> #endif >> >> +#if PTHREAD_IN_LIBC >> + __libc_cleanup_region_end (0); >> +#else >> pthread_cleanup_pop (0); >> +#endif >> } >> > > Ok. What prevents to use __libc_cleanup_region_start on Hurd as well here? I assumed that it would be available only within libc. I have no way to test this on Hurd, which is why I wanted to keep the original code. Thanks, Florian