From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 633503857C6F for ; Thu, 8 Oct 2020 11:32:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 633503857C6F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-538-S9rqdVTFMdaI-8nLHyQKmA-1; Thu, 08 Oct 2020 07:32:10 -0400 X-MC-Unique: S9rqdVTFMdaI-8nLHyQKmA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C6D28030A2; Thu, 8 Oct 2020 11:32:09 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8299650B44; Thu, 8 Oct 2020 11:32:08 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 04/28] elf: Extract command-line/environment variables state from rtld.c References: <37a8980cbc26bdd47c4e4c7b17e373c4f76b71e0.1601569371.git.fweimer@redhat.com> <34591e0e-cb79-1483-db87-d138d7af4f6d@linaro.org> Date: Thu, 08 Oct 2020 13:32:05 +0200 In-Reply-To: <34591e0e-cb79-1483-db87-d138d7af4f6d@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 6 Oct 2020 17:45:54 -0300") Message-ID: <87tuv5eyx6.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 11:32:14 -0000 * Adhemerval Zanella via Libc-alpha: >> +/* This is a list of all the modes the dynamic loader can be in. */ >> +enum mode { normal, list, verify, trace }; >> + > > With this enum now outside rtld.c maybe it would be better to use more > explicit identifiers? I pushed this with this suggested change as: commit 2bf9e641fd50ec34b04b70829679abf64fc0ed78 Author: Florian Weimer Date: Thu Oct 8 10:57:09 2020 +0200 elf: Extract command-line/environment variables state from rtld.c Introduce struct dl_main_state and move it to . Rename enum mode to enum rtld_mode and add the rtld_mode_ prefix to the enum constants. This avoids the need for putting state that is only needed during startup into the ld.so data segment. It also includes the __glibc_likely/__glibc_unlikely changes. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill