From: Florian Weimer <fw@deneb.enyo.de>
To: Simon Marchi via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] Makeconfig: Use $(error ...) to output error message
Date: Wed, 29 Apr 2020 11:25:56 +0200 [thread overview]
Message-ID: <87tv12ej8b.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <6fbf8a68-a6b3-ac8e-4ed8-94bae46b2e7d@efficios.com> (Simon Marchi via Libc-alpha's message of "Tue, 28 Apr 2020 19:48:14 -0400")
* Simon Marchi via Libc-alpha:
> On 2020-04-28 7:33 p.m., Joseph Myers wrote:
>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
>>
>>> Being not familiar with the glibc repository, I typed "make" inside some
>>> subdirectory that has a Makefile, and was met with:
>>>
>>> $ make
>>> ../Makeconfig:42: *** missing separator. Stop.
>>>
>>> At Makeconfig:42, we have:
>>>
>>> objdir must be defined by the build-directory Makefile.
>>>
>>> Change that to use $(error ...), which I guess was the original
>>> intention. The result is:
>>
>> This patch is OK.
>
> Thanks, could you please push it for me? I don't have write access to the
> glibc repo (and don't plan to make enough contributions to justify it).
I have pushed this for you, although I don't think the error message
is a clear improvement. It still does not tell the casual user what
they did wrong.
next prev parent reply other threads:[~2020-04-29 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 22:20 Simon Marchi
2020-04-28 23:33 ` Joseph Myers
2020-04-28 23:48 ` Simon Marchi
2020-04-29 9:25 ` Florian Weimer [this message]
2020-04-29 13:51 ` Simon Marchi
2020-04-30 22:31 ` Maciej W. Rozycki
2020-05-01 0:22 ` Simon Marchi
2020-05-01 16:20 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv12ej8b.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).