From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id A326338930CB
 for <libc-alpha@sourceware.org>; Wed, 29 Apr 2020 09:25:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A326338930CB
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1jTiya-0007Cu-6i; Wed, 29 Apr 2020 09:25:56 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1jTiya-0005t7-42; Wed, 29 Apr 2020 11:25:56 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Simon Marchi via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
 Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] Makeconfig: Use $(error ...) to output error message
References: <20200428222024.3266407-1-simon.marchi@efficios.com>
 <alpine.DEB.2.21.2004282333340.21260@digraph.polyomino.org.uk>
 <6fbf8a68-a6b3-ac8e-4ed8-94bae46b2e7d@efficios.com>
Date: Wed, 29 Apr 2020 11:25:56 +0200
In-Reply-To: <6fbf8a68-a6b3-ac8e-4ed8-94bae46b2e7d@efficios.com> (Simon Marchi
 via Libc-alpha's message of "Tue, 28 Apr 2020 19:48:14 -0400")
Message-ID: <87tv12ej8b.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 09:25:58 -0000

* Simon Marchi via Libc-alpha:

> On 2020-04-28 7:33 p.m., Joseph Myers wrote:
>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
>> 
>>> Being not familiar with the glibc repository, I typed "make" inside some
>>> subdirectory that has a Makefile, and was met with:
>>>
>>>     $ make
>>>     ../Makeconfig:42: *** missing separator.  Stop.
>>>
>>> At Makeconfig:42, we have:
>>>
>>>     objdir must be defined by the build-directory Makefile.
>>>
>>> Change that to use $(error ...), which I guess was the original
>>> intention.  The result is:
>> 
>> This patch is OK.
>
> Thanks, could you please push it for me?  I don't have write access to the
> glibc repo (and don't plan to make enough contributions to justify it).

I have pushed this for you, although I don't think the error message
is a clear improvement.  It still does not tell the casual user what
they did wrong.