From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 984C338930CB for ; Wed, 29 Apr 2020 15:18:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 984C338930CB Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-26_NSt3YPkymUai2W2Q62w-1; Wed, 29 Apr 2020 11:18:47 -0400 X-MC-Unique: 26_NSt3YPkymUai2W2Q62w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E569800C78; Wed, 29 Apr 2020 15:18:46 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-9.ams2.redhat.com [10.36.114.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BAFB1001281; Wed, 29 Apr 2020 15:18:45 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH 2/2] Add C wrappers for prctl/process_vm_readv/process_vm_writev [BZ #25810] References: <20200429144727.3769136-1-hjl.tools@gmail.com> <20200429144727.3769136-2-hjl.tools@gmail.com> <874kt2s5id.fsf@oldenburg2.str.redhat.com> Date: Wed, 29 Apr 2020 17:18:43 +0200 In-Reply-To: (H. J. Lu's message of "Wed, 29 Apr 2020 08:10:56 -0700") Message-ID: <87tv12qq0c.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:18:50 -0000 * H. J. Lu: > On Wed, Apr 29, 2020 at 7:58 AM Florian Weimer wrote= : >> >> * H. J. Lu: >> >> > Since the the U marker can only be applied to 2 unsigned long argument= s, >> > add a C wrapper for prctl, process_vm_readv and process_vm_writev sysc= als >> > which have more than 2 unsigned long arguments. >> >> I forgot: Please mention syscalls.list somewhere in the commit message, >> so that it is clear that the U marker refers to that. >> >> Thanks, >> Florian > > This is I am going to push: > > commit 86f4f2263bf21ff7f80905b3062c16213b016fe6 (HEAD -> master) > Author: H.J. Lu > Date: Wed Apr 29 08:08:40 2020 -0700 > > Mark unsigned long arguments with U in more syscalls [BZ #25810] > > Mark unsigned long arguments in mmap, read, recv, recvfrom, send, sen= dto, > write, ioperm, sendfile64, setxattr, lsetxattr, fsetxattr, getxattr, > lgetxattr, fgetxattr, listxattr, llistxattr and flistxattr with U in > syscalls.list files. This is for the other commit. In that context, U is clear. It is less clear for the prctl/process_vm_readv/process_vm_writev commit. Thanks, Florian