From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id D8A0B385BF83
 for <libc-alpha@sourceware.org>; Mon,  6 Apr 2020 19:19:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8A0B385BF83
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1jLXH3-00067e-FZ; Mon, 06 Apr 2020 19:19:09 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1jLXH3-0002CZ-BH; Mon, 06 Apr 2020 21:19:09 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org>
Cc: Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] linux: wait4: Fix incorrect return value comparison
References: <20200406183921.530591-1-alistair.francis@wdc.com>
Date: Mon, 06 Apr 2020 21:19:09 +0200
In-Reply-To: <20200406183921.530591-1-alistair.francis@wdc.com> (Alistair
 Francis via Libc-alpha's message of "Mon, 6 Apr 2020 11:39:21 -0700")
Message-ID: <87tv1wbexe.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Apr 2020 19:19:13 -0000

* Alistair Francis via Libc-alpha:

> Path 600f00b "linux: Use long time_t for wait4/getrusage" introduced
> two bugs:
>  - The usage32 struct was set if the wait4 syscall had an error.
>  - For 32-bit systems the usage struct was set even if it was specified
>    as NULL.
>
> This patch fixes the two issues.

Would it make sense to add a test case?