From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-109876-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 90075 invoked by alias); 18 Feb 2020 13:05:58 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 90055 invoked by uid 89); 18 Feb 2020 13:05:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*i:sk:c1688ae, H*f:sk:c1688ae
X-HELO: us-smtp-1.mimecast.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1582031155;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ylaVFEdbW/cUKsEQ1CbmGKiVZq70JS+yyBpbqDOzsgI=;
	b=CG02b4YRhXzpRov5NezBdGGZUhUqXi/4LGZ4qFCAmQJ15Oj0w102vyZhYsSeuBK4JtLsm3
	8nU+5SAvLUhytEv93ma8u4R6NT7y47bBk38HJ2HsiscjZeUxSck092gdLP8OiEgKsV/idj
	/Vwyg2e6qvY3bhJ86o5kEjPBBIpdV7w=
From: Florian Weimer <fweimer@redhat.com>
To: Stefan Liebler <stli@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Move implementation of <file_change_detection.h> into a C file
References: <87tv3pqwpr.fsf@oldenburg2.str.redhat.com>
	<c1688ae0-59d9-36e7-a5dd-a88f0a2a2df3@linux.ibm.com>
Date: Tue, 18 Feb 2020 13:05:00 -0000
In-Reply-To: <c1688ae0-59d9-36e7-a5dd-a88f0a2a2df3@linux.ibm.com> (Stefan
	Liebler's message of "Tue, 18 Feb 2020 13:07:01 +0100")
Message-ID: <87tv3ogi4x.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2020-02/txt/msg00782.txt.bz2

* Stefan Liebler:

> Hi Florian,
>
> I've run some builds on my s390x and x86_64 machines with your applied
> patch. I do not see the -Werror=3Dmaybe-uninitialized anymore.
>
> Despite of the whitespace issues, this patch looks good to me.
>
> At least the second line of arguments for __file_is_unchanged needs
> two more spaces (see below).
>
> I've also opened include/file_change_detection.h and
> io/file_change_detection.c in my emacs and it showed more whitespace
> errors: tab vs whitespaces.
> Please have a look at the attached patch to see what I mean. I'm not
> exactly sure if this is really required. If yes, please also check the
> remaining files in the patch.

Thanks.  I believe I fixed up the whitespace issues and pushed the
patch.

Florian