From: Florian Weimer <fw@deneb.enyo.de>
To: Kamlesh Kumar <kamleshbhalui@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] For Adding clang check
Date: Thu, 28 Nov 2019 18:52:00 -0000 [thread overview]
Message-ID: <87tv6n7s0t.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20191128184733.27377-1-kamleshbhalui@gmail.com> (Kamlesh Kumar's message of "Fri, 29 Nov 2019 00:17:33 +0530")
* Kamlesh Kumar:
> ChangeLog :
>
> 2019-11-28 Kamlesh Kumar <kamleshbhalui@gmail.com>
>
> * string/string.h (__glibc_clang_prereq): Used.
> ---
> string/string.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/string/string.h b/string/string.h
> index 73c22a535a..06a8977165 100644
> --- a/string/string.h
> +++ b/string/string.h
> @@ -33,7 +33,7 @@ __BEGIN_DECLS
> #include <stddef.h>
>
> /* Tell the caller that we provide correct C++ prototypes. */
> -#if defined __cplusplus && __GNUC_PREREQ (4, 4)
> +#if defined __cplusplus && (__GNUC_PREREQ (4, 4) || __glibc_clang_prereq(3,5))
> # define __CORRECT_ISO_CPP_STRING_H_PROTO
> #endif
Sorry, what's the purpose of this change? Thanks.
If it fixes a user-visible problem, it should reference a bug in
Bugzilla.
next prev parent reply other threads:[~2019-11-28 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 18:47 Kamlesh Kumar
2019-11-28 18:52 ` Florian Weimer [this message]
2019-11-29 0:47 ` kamlesh kumar
2019-11-29 8:26 ` Florian Weimer
2019-11-29 9:50 ` kamlesh kumar
2019-11-29 10:58 ` Jonathan Wakely
2019-11-29 11:38 ` Florian Weimer
2019-12-05 15:51 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv6n7s0t.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=kamleshbhalui@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).