From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58058 invoked by alias); 10 Dec 2018 18:38:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 58032 invoked by uid 89); 10 Dec 2018 18:38:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: goldenrod.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Tasty-Interest: 1ee5ed1c6dcc9d24_1544467116057_4238271402 X-MC-Loop-Signature: 1544467116056:3811970146 X-MC-Ingress-Time: 1544467116056 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=ascii.art.br; h=from:to:cc :cc:subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=ascii.art.br; bh=JKp0 w7T07zppLbdBh2uzofMlrJU=; b=Qjhhxofo2cC50c/iEEnYFCiL4ZWSZIDhpOdw PsGQi3fW54Cl3U7jmS9VAdG+aLz7Vqvhg0mVAVf3lGEuRsbQdPUNvTgFmwE9g3ti OAgpWtpW1lpkA8T3KkAT2AiXdOZUw7QNoGo8kuKD+3CZWDhaekioPpxx0s4giWuC l5E5ofE= X-DH-BACKEND: pdx1-sub0-mail-a1 From: Tulio Magno Quites Machado Filho To: "Gabriel F. T. Gomes" , Rogerio Alves Cc: Florian Weimer , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH] power: Fix VSCR position on ucontext In-Reply-To: <20181210153658.32b0e266@tereshkova> References: <8a619ad1-b7f2-04f8-f9a7-0a19cbf98f4c@linux.ibm.com> <87lg5va6a6.fsf@oldenburg.str.redhat.com> <20181116111825.43b60283@tereshkova.br.ibm.com> <5e1d1cab-7c91-90f8-82d2-fd38f8676f30@linux.ibm.com> <20181207162959.5e5d8933@tereshkova> <20181210153658.32b0e266@tereshkova> User-Agent: Notmuch/0.27 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu) Date: Mon, 10 Dec 2018 21:20:00 -0000 Message-ID: <87tvjl8bx7.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudeghedgudduhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqeenucffohhmrghinhepshhouhhrtggvfigrrhgvrdhorhhgnecukfhppeduledurddujedruddvvddrudeludenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheprghstghiihdrrghrthdrsghrpdhinhgvthepudeluddrudejrdduvddvrdduledupdhrvghtuhhrnhdqphgrthhhpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqedpmhgrihhlfhhrohhmpehtuhhlihhomhesrghstghiihdrrghrthdrsghrpdhnrhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2018-12/txt/msg00328.txt.bz2 "Gabriel F. T. Gomes" writes: > On Fri, 07 Dec 2018, Gabriel F. T. Gomes wrote: > >>On Fri, 07 Dec 2018, Rogerio Alves wrote: >> >>>+/* This test is supported only on POWER 5 or higher. */ >>>+#define PPC_CPU_SUPPORTED (PPC_FEATURE_POWER5 | PPC_FEATURE_POWER5_PLUS= | \ >>>+ PPC_FEATURE_ARCH_2_05 | PPC_FEATURE_ARCH_2_0= 6 | \ >>>+ PPC_FEATURE2_ARCH_2_07)=20=20 >> >>Is this actually needed? Glibc has code to fill all the bits for older >>architectures in sysdeps/powerpc/hwcapinfo.c [1]. So, as far as I can >>see, you only need to test for AT_HWCAP & PPC_FEATURE_POWER5. >> >>[1] https://sourceware.org/git/?p=3Dglibc.git;a=3Dblob;f=3Dsysdeps/powerp= c/hwcapinfo.c;h=3Da09b18309324423d0cdf04e88367899a4396bab7;hb=3DHEAD#l47 > > Hrm, that's only true for the hwcap info that is copied into the TCB, not > when accessing it with getauxval, so my comment is wrong (as Rogerio > kindly pointed out to me in a private message... thanks). > > So, nevermind this comment. > > > On the other hand, on powerpc64 builds configured with --with-cpu set to > power4, power5, and power6, (but not to power8 or power7), I got the > following error message: > > ../sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c: In function =E2= =80=98do_test=E2=80=99: > ../sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c:51:3: error: incon= sistent operand constraints in an =E2=80=98asm=E2=80=99 > asm volatile ("vspltisb %0,0\n" > ^~~ > > I guess we didn't get this error message before, because of the > `#ifdef ARCH_PWR8' statement. So, unless you know a better way to fix > this, you should reintroduce the `#ifdef' statement (now, you could use > ARCH_PWR7). You can use: .machine push; .machine "power7"; ... .machine pop It should be safe to use with the current minimum required Binutils i.e. support for POWER7 was already available in GNU Binutils 2.25 (even P8 was supported). --=20 Tulio Magno