public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
	 GNU C Library <libc-alpha@sourceware.org>,
	 pc@us.ibm.com,  "Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCHv2] Add a way to bypass the PLT when calling getauxval
Date: Fri, 09 Jun 2017 13:34:00 -0000	[thread overview]
Message-ID: <87tw3pi8td.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOou63sp--WS5cET8L82oXREsoGBwEmxYcX6eh_UZY0dsw@mail.gmail.com> (H. J. Lu's message of "Fri, 9 Jun 2017 06:29:07 -0700")

"H.J. Lu" <hjl.tools@gmail.com> writes:

>>> diff --git a/misc/getauxval.c b/misc/getauxval.c
>>> index c83fbce..14f4298 100644
>>> --- a/misc/getauxval.c
>>> +++ b/misc/getauxval.c
>>> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type)
>>>  }
>>>
>>>  weak_alias (__getauxval, getauxval)
>>> +libc_hidden_def (__getauxval)
>>> --
>>> 2.1.0
>>>
>
> Which one is better?
>
> https://sourceware.org/ml/libc-alpha/2017-06/msg00332.html

Tulio's patch is better because getauxval references could lead to
namespace violations.

Thanks,
Florian

  reply	other threads:[~2017-06-09 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 19:42 [PATCH] " Tulio Magno Quites Machado Filho
2017-05-24 19:52 ` Joseph Myers
2017-05-24 21:43   ` Tulio Magno Quites Machado Filho
2017-05-25 20:06   ` [PATCHv2] " Tulio Magno Quites Machado Filho
2017-06-09 13:14     ` Tulio Magno Quites Machado Filho
2017-06-09 13:29       ` H.J. Lu
2017-06-09 13:34         ` Florian Weimer [this message]
2017-06-09 13:33     ` Florian Weimer
2017-06-09 15:01       ` Tulio Magno Quites Machado Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw3pi8td.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=pc@us.ibm.com \
    --cc=tuliom@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).