From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89707 invoked by alias); 9 Jun 2017 13:34:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 89667 invoked by uid 89); 9 Jun 2017 13:34:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CCBAC61B8F Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CCBAC61B8F From: Florian Weimer To: "H.J. Lu" Cc: Tulio Magno Quites Machado Filho , GNU C Library , pc@us.ibm.com, "Joseph S. Myers" Subject: Re: [PATCHv2] Add a way to bypass the PLT when calling getauxval References: <1495742765-1722-1-git-send-email-tuliom@linux.vnet.ibm.com> <87zidhb8xf.fsf@linux.vnet.ibm.com> Date: Fri, 09 Jun 2017 13:34:00 -0000 In-Reply-To: (H. J. Lu's message of "Fri, 9 Jun 2017 06:29:07 -0700") Message-ID: <87tw3pi8td.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00390.txt.bz2 "H.J. Lu" writes: >>> diff --git a/misc/getauxval.c b/misc/getauxval.c >>> index c83fbce..14f4298 100644 >>> --- a/misc/getauxval.c >>> +++ b/misc/getauxval.c >>> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type) >>> } >>> >>> weak_alias (__getauxval, getauxval) >>> +libc_hidden_def (__getauxval) >>> -- >>> 2.1.0 >>> > > Which one is better? > > https://sourceware.org/ml/libc-alpha/2017-06/msg00332.html Tulio's patch is better because getauxval references could lead to namespace violations. Thanks, Florian