From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72705 invoked by alias); 19 Apr 2017 14:13:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 72691 invoked by uid 89); 19 Apr 2017 14:13:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mail-out.m-online.net X-Auth-Info: K1rfSAoSoSGYoehq17tDjVlX3x9RO/B452n3I7D2sN5+hm3CD8SMBClRUr2C0t/A From: Andreas Schwab To: fweimer@redhat.com (Florian Weimer) Cc: libc-alpha@sourceware.org Subject: Re: [PATCH COMMITTED] resolv: Replace __builtin_expect with __glibc_unlikely/__glibc_likely References: <20170419123107.5EC36416FD367@oldenburg.str.redhat.com> X-Yow: Yow! I'm imagining a surfer van filled with soy sauce! Date: Wed, 19 Apr 2017 14:13:00 -0000 In-Reply-To: <20170419123107.5EC36416FD367@oldenburg.str.redhat.com> (Florian Weimer's message of "Wed, 19 Apr 2017 14:31:07 +0200") Message-ID: <87tw5k5vu4.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-04/txt/msg00368.txt.bz2 On Apr 19 2017, fweimer@redhat.com (Florian Weimer) wrote: > @@ -633,7 +633,7 @@ getanswer_r (const querybuf *answer, int anslen, const char *qname, int qtype, > packtmp, sizeof packtmp); > if (n != -1 && __ns_name_ntop (packtmp, bp, linebuflen) == -1) > { > - if (__builtin_expect (errno, 0) == EMSGSIZE) > + if (__glibc_unlikely (errno) == EMSGSIZE) (__glibc_unlikely (errno == EMSGSIZE)) Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."