From: Florian Weimer <fw@deneb.enyo.de>
To: Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Update elf tests to use the support test driver.
Date: Sat, 01 Apr 2017 06:58:00 -0000 [thread overview]
Message-ID: <87tw68ehs5.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <a51ff7cf-7103-15aa-48ab-eacb1fcd6ccf@linux.vnet.ibm.com> (Wainer dos Santos Moschetta's message of "Fri, 31 Mar 2017 17:52:27 -0300")
* Wainer dos Santos Moschetta:
> Side note: the original tst-tls-manydynamic.c code uses xpthread_*
> functions. So I had to include support/xthread.h to avoid its
> breakage. In test-skeleton.c you can see the following:
>
> #ifdef _PTHREAD_H
> # include <support/xthread.h>
> #endif /* _PTHREAD_H */
>
> So I'm considering to add this same block in test-driver.c since it
> will ease the migration of tests that use xpthread_*. Any objection to
> this change?
#include <support/test-driver.c> really should remain at the end of
the file, so adding this preprocessor conditional to
support/test-driver.c will not have the desired effect. Please add
the #include directive to the beginning of the file.
And I think less magic is generally better.
next prev parent reply other threads:[~2017-04-01 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:14 Wainer dos Santos Moschetta
2017-03-30 20:52 ` Adhemerval Zanella
2017-03-30 20:55 ` Florian Weimer
2017-03-30 21:00 ` Adhemerval Zanella
2017-03-30 21:01 ` Florian Weimer
2017-03-31 20:53 ` Wainer dos Santos Moschetta
2017-04-01 6:58 ` Florian Weimer [this message]
2017-04-01 13:58 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw68ehs5.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=wainersm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).