From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50984 invoked by alias); 1 Apr 2017 06:58:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50958 invoked by uid 89); 1 Apr 2017 06:58:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*r:4.88 X-HELO: albireo.enyo.de From: Florian Weimer To: Wainer dos Santos Moschetta Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Update elf tests to use the support test driver. References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com> <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> <87mvc2scv8.fsf@mid.deneb.enyo.de> Date: Sat, 01 Apr 2017 06:58:00 -0000 In-Reply-To: (Wainer dos Santos Moschetta's message of "Fri, 31 Mar 2017 17:52:27 -0300") Message-ID: <87tw68ehs5.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-04/txt/msg00000.txt.bz2 * Wainer dos Santos Moschetta: > Side note: the original tst-tls-manydynamic.c code uses xpthread_* > functions. So I had to include support/xthread.h to avoid its > breakage. In test-skeleton.c you can see the following: > > #ifdef _PTHREAD_H > # include > #endif /* _PTHREAD_H */ > > So I'm considering to add this same block in test-driver.c since it > will ease the migration of tests that use xpthread_*. Any objection to > this change? #include really should remain at the end of the file, so adding this preprocessor conditional to support/test-driver.c will not have the desired effect. Please add the #include directive to the beginning of the file. And I think less magic is generally better.