From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-77195-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 90867 invoked by alias); 6 Feb 2017 22:59:24 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 88425 invoked by uid 89); 6 Feb 2017 22:59:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=1.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=U*siddhesh, siddheshsourcewareorg, siddhesh@sourceware.org, GPG
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-out.m-online.net
X-Auth-Info: fDkEMTf3Q2Zfov5NpWfY8LTHLnlVC20osAsWwThFa/6dpMXZUbJcRfvvq6i4sGCM
From: Andreas Schwab <schwab@linux-m68k.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org,  fweimer@redhat.com,  carlos@redhat.com
Subject: Re: [PATCH 1/4] Add framework for tunables
References: <1483070938-2308-1-git-send-email-siddhesh@sourceware.org>
	<1483070938-2308-2-git-send-email-siddhesh@sourceware.org>
X-Yow: Hello.  Just walk along and try NOT to think about your
 INTESTINES being almost FORTY YARDS LONG!!
Date: Mon, 06 Feb 2017 22:59:00 -0000
In-Reply-To: <1483070938-2308-2-git-send-email-siddhesh@sourceware.org>
	(Siddhesh Poyarekar's message of "Fri, 30 Dec 2016 09:38:55 +0530")
Message-ID: <87tw87c4ea.fsf@linux-m68k.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2017-02/txt/msg00100.txt.bz2

On Dez 30 2016, Siddhesh Poyarekar <siddhesh@sourceware.org> wrote:

> +/* Set the tunable value.  This is called by the module that the tunable exists
> +   in. */
> +void
> +__tunable_set_val (tunable_id_t id, void *valp, tunable_callback_t callback)
> +{
> +  tunable_t *cur = &tunable_list[id];
> +
> +  /* Don't do anything if our tunable was not set during initialization or if
> +     it failed validation.  */
> +  if (cur->strval == NULL)
> +    return;
> +
> +  if (valp == NULL)
> +    goto cb;

Why goto?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."