From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30280 invoked by alias); 23 Sep 2016 05:21:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 30227 invoked by uid 89); 23 Sep 2016 05:21:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HTo:D*dk X-HELO: albireo.enyo.de From: Florian Weimer To: Rasmus Villemoes Cc: libc-alpha@sourceware.org, Adhemerval Zanella , Joseph Myers Subject: Re: [PATCH] linux: spawni.c: simplify error reporting to parent References: <877fa6nwsl.fsf@mid.deneb.enyo.de> <1474405260-16657-1-git-send-email-rv@rasmusvillemoes.dk> Date: Fri, 23 Sep 2016 05:21:00 -0000 In-Reply-To: <1474405260-16657-1-git-send-email-rv@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 20 Sep 2016 23:01:00 +0200") Message-ID: <87twd7jio2.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-09/txt/msg00479.txt.bz2 * Rasmus Villemoes: > + ec =3D args.err; > + assert (ec >=3D 0); > + if (ec !=3D 0) > + __waitpid (new_pid, NULL, 0); One minor issue: Now that the variable name =E2=80=9Cec=E2=80=9D appears in= an assertion, it is a good idea to rename it to =E2=80=9Cerror_code_from_child= =E2=80=9C or something similar, so that the assertion message is more meaningful.