From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2962F3858418 for ; Tue, 19 Mar 2024 12:17:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2962F3858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2962F3858418 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710850630; cv=none; b=SgebUx579MzKyz8OFyjKBx4CcvnYTZIk69ekefj/z6jj0UrffaQFd8LGKM/TqXavG6EgzVofGk42MVQJPQqVAxVFbGglT4/ZJzHLKXNQhzrSXQ/hxJSRcoSPsqn4GIyKMXq50PonF4ZQamdKouu2xc9hEtVQjuyQkUVHiVQSlFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710850630; c=relaxed/simple; bh=hyTW0M9XcoudyVgtWgNmYVBDXSjucDVSWWBKVEcqcto=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wias5ABWznYuqTLwFPUcEdL4pkGlZlYbESwN4SfJNunl7fslSbNpQCsdl+nCtjxrHtbIN3vOeTKLA6kfPpYkkNGlZCq8ClfVeC+64Cky95lyeqpXiq4uVdaaE8n5+Az6tU/WALOuACXJlcxndQcCxcXIOzcQD7P0BLmTrIO85ME= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710850626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n45dDUqIrK60dcqNu/o95p9DSSbnFq59ZnMLFirgkYk=; b=OXs1bjW5m1GNCLOejaWnMfs54z8R3Nt70QgFXak+LY+ReXtdJB0kfd6YI5lAQKz5LnWB2F Xv7NBjuoI0eR7WX7T+AaXkw60EphBIObe0pvY5snyB6yQqx9q4T7XC01UQnbfTDseoocd7 0CAxJpIYy1kjlsHUdKc7K9YL/x7TnJY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-oQz3hWOLON-D4iFILfaOLA-1; Tue, 19 Mar 2024 08:17:03 -0400 X-MC-Unique: oQz3hWOLON-D4iFILfaOLA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A30C800268; Tue, 19 Mar 2024 12:17:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B48782166B36; Tue, 19 Mar 2024 12:17:01 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: "H.J. Lu" , libc-alpha@sourceware.org, skpgkp2@gmail.com, goldstein.w.n@gmail.com Subject: Re: [PATCH v6] x86-64: Allocate state buffer space for RDI, RSI and RBX References: <20240318134016.820218-1-hjl.tools@gmail.com> Date: Tue, 19 Mar 2024 13:16:55 +0100 In-Reply-To: (Andreas Schwab's message of "Tue, 19 Mar 2024 12:21:55 +0100") Message-ID: <87v85il8lk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Andreas Schwab: > On M=C3=A4r 19 2024, H.J. Lu wrote: > >> On Tue, Mar 19, 2024 at 1:31=E2=80=AFAM Andreas Schwab = wrote: >>> >>> On M=C3=A4r 18 2024, H.J. Lu wrote: >>> >>> > diff --git a/sysdeps/x86_64/tst-gnu2-tls2mod1.S b/sysdeps/x86_64/tst-= gnu2-tls2mod1.S >>> > new file mode 100644 >>> > index 0000000000..1d636669ba >>> > --- /dev/null >>> > +++ b/sysdeps/x86_64/tst-gnu2-tls2mod1.S >>> > @@ -0,0 +1,87 @@ >>> > +/* Check if TLSDESC relocation preserves %rdi, %rsi and %rbx. >>> > + Copyright (C) 2024 Free Software Foundation, Inc. >>> > + This file is part of the GNU C Library. >>> > + >>> > + The GNU C Library is free software; you can redistribute it and/o= r >>> > + modify it under the terms of the GNU Lesser General Public >>> > + License as published by the Free Software Foundation; either >>> > + version 2.1 of the License, or (at your option) any later version= . >>> > + >>> > + The GNU C Library is distributed in the hope that it will be usef= ul, >>> > + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> > + Lesser General Public License for more details. >>> > + >>> > + You should have received a copy of the GNU Lesser General Public >>> > + License along with the GNU C Library; if not, see >>> > + . */ >>> > + >>> > +#include >>> >>> A testsuite module cannot include non-installed headers. >>> >> >> This is a very special case. Does it cause any issues? > > sysdep.h generally depends on definitions in config.h. It seems to be a downstream-specific patch: [ 1518s] In file included from ../sysdeps/unix/x86_64/sysdep.h:19, [ 1518s] from ../sysdeps/unix/sysv/linux/x86_64/sysdep.h:2= 3, [ 1518s] from ../sysdeps/x86_64/tst-gnu2-tls2mod1.S:19: [ 1518s] ../sysdeps/x86_64/sysdep.h:56:5: error: "ENABLE_USERSPACE_LIVEPATC= H" is not defined, evaluates to 0 [-Werror=3Dundef] [ 1518s] 56 | #if ENABLE_USERSPACE_LIVEPATCH [ 1518s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~ [ 1518s] cc1: some warnings being treated as errors I think the module using needs to be added to the test-internal-extras Makefile variable. Thanks, Florian