From: Florian Weimer <fw@deneb.enyo.de>
To: Evan Green <evan@rivosinc.com>
Cc: Florian Weimer <fweimer@redhat.com>,
libc-alpha@sourceware.org, vineetg@rivosinc.com,
slewis@rivosinc.com, palmer@rivosinc.com
Subject: Re: [PATCH v12 2/7] linux: Introduce INTERNAL_VSYSCALL
Date: Mon, 26 Feb 2024 18:07:49 +0100 [thread overview]
Message-ID: <87v86byx0a.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CALs-HstMGOZuck8tq8S=bhv9tWz3chqNkptnA73w2EiGptbxeQ@mail.gmail.com> (Evan Green's message of "Mon, 26 Feb 2024 08:47:46 -0800")
* Evan Green:
> I like it! I'm guessing I should continue to use the
> INTERNAL_SYSCALL_ERRNO_P() and INTERNAL_SYSCALL_ERRNO(), and you
> omitted it for example's sake. Will plan to spin with this.
We already hard-code the Linux convention in a few places, e.g.
sysdeps/unix/sysv/linux/fstatat64.c,
sysdeps/unix/sysv/linux/clock_gettime.c. I don't think the macros add
value here. We also don't have a macro to inject the error code, I
believe, so one -ENOSYS will stick around. But I don't feel strongly
about it.
next prev parent reply other threads:[~2024-02-26 17:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 14:31 [PATCH v12 0/7] RISC-V: ifunced memcpy using new kernel hwprobe interface Evan Green
2024-02-14 14:31 ` [PATCH v12 1/7] riscv: Add Linux hwprobe syscall support Evan Green
2024-02-14 14:31 ` [PATCH v12 2/7] linux: Introduce INTERNAL_VSYSCALL Evan Green
2024-02-16 7:44 ` Florian Weimer
2024-02-23 23:12 ` Evan Green
2024-02-23 23:29 ` Gabriel Ravier
2024-02-24 2:06 ` Richard Henderson
2024-02-24 11:40 ` Florian Weimer
2024-02-26 16:47 ` Evan Green
2024-02-26 17:07 ` Florian Weimer [this message]
2024-02-26 17:57 ` Evan Green
2024-02-14 14:31 ` [PATCH v12 3/7] riscv: Add hwprobe vdso call support Evan Green
2024-02-14 14:31 ` [PATCH v12 4/7] riscv: Add __riscv_hwprobe pointer to ifunc calls Evan Green
2024-02-14 14:31 ` [PATCH v12 5/7] riscv: Enable multi-arg ifunc resolvers Evan Green
2024-02-16 7:45 ` Florian Weimer
2024-02-14 14:31 ` [PATCH v12 6/7] riscv: Add ifunc helper method to hwprobe.h Evan Green
2024-02-14 14:31 ` [PATCH v12 7/7] riscv: Add and use alignment-ignorant memcpy Evan Green
2024-02-14 15:16 ` [PATCH v12 0/7] RISC-V: ifunced memcpy using new kernel hwprobe interface Adhemerval Zanella Netto
2024-02-14 15:24 ` Andreas Schwab
2024-02-22 18:44 ` Palmer Dabbelt
2024-02-15 15:48 ` Evan Green
2024-02-15 15:57 ` enh
2024-02-15 16:50 ` Palmer Dabbelt
2024-02-15 17:00 ` enh
2024-02-15 17:22 ` Palmer Dabbelt
2024-02-15 18:45 ` enh
2024-02-15 18:56 ` Palmer Dabbelt
2024-02-15 17:42 ` Jessica Clarke
2024-02-15 18:52 ` enh
2024-02-15 19:09 ` Jessica Clarke
2024-02-22 19:41 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v86byx0a.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=evan@rivosinc.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@rivosinc.com \
--cc=slewis@rivosinc.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).