From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=A39D=KD=deneb.enyo.de=fw@sourceware.org>
Received: from cygnus.enyo.de (cygnus.enyo.de [79.140.189.114])
	by sourceware.org (Postfix) with ESMTPS id C33053858CDB
	for <libc-alpha@sourceware.org>; Mon, 26 Feb 2024 17:07:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C33053858CDB
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C33053858CDB
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=79.140.189.114
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708967275; cv=none;
	b=H5mDO/kovcPpOHQIaEwy9yRPc7XzhPMqN78HnAnq511a2JggEGYu48jXZcDz48H7sz1RsAh+NxJL1Mpr30t7VeWtA3IQuO5uj7C68iz6RLYK7MqTCb4ZuLAEk+pO4Fq5HVxa2iL45rezOrjjCQ+3idRBtFMkONjDi2/3o+okzso=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1708967275; c=relaxed/simple;
	bh=bkD04bWeCUQD7fiRwZC+e/xohEkF7MNpywzWf8Nu8hM=;
	h=From:To:Subject:Date:Message-ID:MIME-Version; b=BPSkyxR1druCJV0lP+WTWkZPZSKDF8415uRXAMWDEnm9j/lWGHcYgUXD+ufKPUgQxgEw2cHFUjmC654ja3781msJfrS4fvuUSrFf/KoIOQpLp7kefbIsL4q+K7uN5cPnqErtTC2AdAzMzchTPdOkUO+ZVjLj5TDN6mvCDdkrkls=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from [172.17.203.2] (port=40083 helo=deneb.enyo.de)
	by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	id 1reeSC-009bFD-JR; Mon, 26 Feb 2024 17:07:49 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.96)
	(envelope-from <fw@deneb.enyo.de>)
	id 1reeSD-000nH3-20;
	Mon, 26 Feb 2024 18:07:49 +0100
From: Florian Weimer <fw@deneb.enyo.de>
To: Evan Green <evan@rivosinc.com>
Cc: Florian Weimer <fweimer@redhat.com>,  libc-alpha@sourceware.org,
  vineetg@rivosinc.com,  slewis@rivosinc.com,  palmer@rivosinc.com
Subject: Re: [PATCH v12 2/7] linux: Introduce INTERNAL_VSYSCALL
References: <20240214143159.2951158-1-evan@rivosinc.com>
	<20240214143159.2951158-3-evan@rivosinc.com>
	<877cj47t0f.fsf@oldenburg.str.redhat.com>
	<CALs-Hsu8B05YL2-6GanDdRLqtxPK=xf4eLPJ4xbD0K=Y5YcVhg@mail.gmail.com>
	<87sf1iw0nu.fsf@mid.deneb.enyo.de>
	<CALs-HstMGOZuck8tq8S=bhv9tWz3chqNkptnA73w2EiGptbxeQ@mail.gmail.com>
Date: Mon, 26 Feb 2024 18:07:49 +0100
In-Reply-To: <CALs-HstMGOZuck8tq8S=bhv9tWz3chqNkptnA73w2EiGptbxeQ@mail.gmail.com>
	(Evan Green's message of "Mon, 26 Feb 2024 08:47:46 -0800")
Message-ID: <87v86byx0a.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Evan Green:

> I like it! I'm guessing I should continue to use the
> INTERNAL_SYSCALL_ERRNO_P() and INTERNAL_SYSCALL_ERRNO(), and you
> omitted it for example's sake. Will plan to spin with this.

We already hard-code the Linux convention in a few places, e.g.
sysdeps/unix/sysv/linux/fstatat64.c,
sysdeps/unix/sysv/linux/clock_gettime.c.  I don't think the macros add
value here.  We also don't have a macro to inject the error code, I
believe, so one -ENOSYS will stick around.  But I don't feel strongly
about it.