public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 0/3] Fine-tune ELF destructor ordering (bug 30869)
Date: Fri, 06 Oct 2023 14:35:20 +0200	[thread overview]
Message-ID: <87v8bkdj3r.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <cover.1695113064.git.fweimer@redhat.com> (Florian Weimer's message of "Tue, 19 Sep 2023 10:48:09 +0200")

* Florian Weimer:

> It turns out that we cannot simply reverse the constructor ordering.
> Some applications expect that the main program is destructed first.
> It also seems reasonable to assume that some applications depend
> on the destructor ordering resulting from explicit dlclose calls
> upon exit time (destructors calling dlclose).
>
> The change in main program destructor ordering went unnoticed because
> the DSO ordering test framework did not record main program
> constructor/destructor calls, so the first commit fixes that omission.

Further testing shows that doesn't work.  We need to revert the ordering
changes (patches already posted).  I'm testing a completely different
approach with downstream patches.

Thanks,
Florian


      parent reply	other threads:[~2023-10-06 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  8:48 Florian Weimer
2023-09-19  8:48 ` [PATCH 1/3] elf: Record main program constructor/destructor in ordering tests Florian Weimer
2023-09-19  8:56   ` Andreas Schwab
2023-09-19  9:30     ` Florian Weimer
2023-09-19 12:41   ` Carlos O'Donell
2023-09-19 12:47     ` Florian Weimer
2023-09-19 14:24       ` Carlos O'Donell
2023-09-19 14:41         ` Florian Weimer
2023-09-19  8:48 ` [PATCH 2/3] elf: Add dummy declaration of _dl_audit_objclose for !SHARED Florian Weimer
2023-09-19 12:43   ` Carlos O'Donell
2023-09-19  8:48 ` [PATCH 3/3] elf: Process initially loaded objects first in _dl_fini (bug 30869) Florian Weimer
2023-10-06 12:35 ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8bkdj3r.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).