Re: [PATCH 2/3] manual: Document ld.so --list-diagnostics output

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella Netto:

>> +Output lines can be parsed with the following Python function.  It
>> +assumes lines formatted according to the ABNF @code{line} production
>> +above.
>
> I don't think it would be useful to add the python script example below,
> it is not an full example (reader will need to fill the blacks to actually
> run it) and he ABNF description should be suffice.

I'm going to remove it.

>> +As mentioned above, the set of diagnostics may change between
>> +@theglibc{} releases.  Nevertheless, the following table documents a few
>> +common diagnostic items.
>> +
>> +@table @code
>> +@item dl_dst_lib=@var{string}
>> +The @code{$LIB} dynamic string token expands to @var{string}.
>
> s/to/to a

I think @var{string} as a variable should not have an article.

>> +
>> +@item dl_hwcap=@var{integer}
>> +@itemx dl_hwcap2=@var{integer}
>> +@cindex HWCAP (diagnostics)
>> +The HWCAP and HWCAP2 values, as returned for @code{getauxval}, and as
>> +used in other places depending on the architecture.
>> +
>> +@item dl_pagesize=@var{integer}
>> +@cindex page size (diagnostics)
>> +The system page size is @var{integer} bytes.
>
> Maybe add it is in hexadecimal.

I'm going to add a sentence to the introductory paragraph:

All numbers are in hexadecimal, with a @samp{0x} prefix.

I've applied the rest of your suggestions.

Thanks,
Florian