From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xBen=BT=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by sourceware.org (Postfix) with ESMTPS id 3F82F3858D20
	for <libc-alpha@sourceware.org>; Tue, 30 May 2023 11:51:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F82F3858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1685447490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iEf67KKqsTC3ndu6BdRALaZB1PWIMj7GtA0OAppiDDI=;
	b=gKz0FR9wOSkXGlVPBtle2JYPCfa6sHsrdg7+LPXXrBmB0YEVwIIfMnUBNUHt+V4TTbTp3J
	FObwZxpyOhXrDPJFjT2/bKmpNGDJaVuDNOB8uG1PuaHt+cTxs1eiLDEOmgqGjsmRe6hrqV
	w2xuxT9nPRYs2MPBpgA9BFJZOOKauUs=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-480-UHjwJSOSNNKvfbA21-RzFQ-1; Tue, 30 May 2023 07:51:29 -0400
X-MC-Unique: UHjwJSOSNNKvfbA21-RzFQ-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6596D1C01512;
	Tue, 30 May 2023 11:51:29 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.38])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 90D1E112132C;
	Tue, 30 May 2023 11:51:28 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>,  libc-alpha@sourceware.org
Subject: Re: [PATCH v2 0/3] fcntl fortification
References: <20230528172013.73111-1-bugaevc@gmail.com>
	<87wn0qw88m.fsf@oldenburg.str.redhat.com>
	<CAN9u=HdxGf8neZ=YToRbieNLftBCSMjqKt5faGgKv6GP3CYgUg@mail.gmail.com>
	<878rd6uleb.fsf@oldenburg.str.redhat.com>
	<CAN9u=He-FyaPYMyYn+wRaC8O68AwEyPyNSqcrpSNVd5-qPBDEg@mail.gmail.com>
Date: Tue, 30 May 2023 13:51:27 +0200
In-Reply-To: <CAN9u=He-FyaPYMyYn+wRaC8O68AwEyPyNSqcrpSNVd5-qPBDEg@mail.gmail.com>
	(Sergey Bugaev's message of "Tue, 30 May 2023 14:34:45 +0300")
Message-ID: <87v8gat4u8.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Sergey Bugaev:

> On Tue, May 30, 2023 at 2:08=E2=80=AFPM Florian Weimer <fweimer@redhat.co=
m> wrote:
>> Ahh, maybe that check is implied by doing this for fortification only?
>
> All of this is only happening within the fortification header, yes,
> that does not even get #included if the preconditions for including it
> fail. The preconditions are currently the same as for the open ()
> fortification due to sharing the same header file, but they are going
> to be different (in v3) because this now needs __VA_OPT__ and __typeof
> but does not need __builtin_va_arg_pack.

Forgot to mention that this suggests that __typeof is actually okay in
the C++ case.

Thanks,
Florian