From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 920E93858D3C for ; Tue, 21 Mar 2023 19:08:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 920E93858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de Received: from [172.17.203.2] (port=50205 helo=deneb.enyo.de) by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1pehLZ-00AsYS-87; Tue, 21 Mar 2023 19:08:37 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.96) (envelope-from ) id 1pehLZ-000TZy-0W; Tue, 21 Mar 2023 20:08:37 +0100 From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: [patch v3] aligned_alloc: conform to C17 References: Date: Tue, 21 Mar 2023 20:08:37 +0100 In-Reply-To: (DJ Delorie's message of "Tue, 21 Mar 2023 13:47:54 -0400") Message-ID: <87v8it3osq.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * DJ Delorie: > Florian Weimer writes: >> I'm surprised that this even compiles. This sort of makes the >> function static and gives it external linkage. > > It almost does the same thing as your example, but follows the > internal/external paradigm we've been using for all the other functions. > > (in your example, just drop the "static", then it's the same) > > And yes, it took Carlos and I a while to go through all this linkage > stuff to make sure we understood it. Yeah, the static was wrong. I think you should avoid the alias if there aren't any internal calls.