From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 622B13858C54 for ; Wed, 8 Mar 2023 09:44:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 622B13858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678268651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQts0kFNBkkGzeabLUpoASQvqiLm6BjZExD3fA0Ny7k=; b=Mx0Pv30MRZODQSzC/ddg8Mlo/PHgXHuva/2fiUXplhwP5mQd3FW43Nip0vQDNGRfOVEDk5 SUCbqKkCWmeZPy04OISYu6Z1KhJlODwLr0uz0YzKdYv4BibtJPcs+OJIZRFKnlIjJHQfc6 COqIhI5mjQCKESoILow9wuVaYxndh18= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-473-4aMxK9eQP4OtW9yD7BXd4g-1; Wed, 08 Mar 2023 04:44:10 -0500 X-MC-Unique: 4aMxK9eQP4OtW9yD7BXd4g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5D98100F90B; Wed, 8 Mar 2023 09:44:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC72140C945A; Wed, 8 Mar 2023 09:44:08 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , "H.J. Lu" Subject: Re: [PATCH] posix: Ensure the initial signal disposition for tst-spawn7 References: <20230307163152.2509362-1-adhemerval.zanella@linaro.org> Date: Wed, 08 Mar 2023 10:44:07 +0100 In-Reply-To: <20230307163152.2509362-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 7 Mar 2023 13:31:52 -0300") Message-ID: <87v8jbshlk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella via Libc-alpha: > To avoid possible failure if any parent set any initial signal > disposition as SIG_IGN. > > Checked on x86_64-linux-gnu. > --- > posix/tst-spawn7.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c > index fedb09fb94..fb06915cb7 100644 > --- a/posix/tst-spawn7.c > +++ b/posix/tst-spawn7.c > @@ -99,6 +99,12 @@ dummy_sa_handler (int signal) > static void > do_test_signals (void) > { > + /* Ensure the initial signal disposition, ignore EINVAL for internal > + signal such as SIGCANCEL. */ > + for (int sig =3D 1; sig < _NSIG; ++sig) > + sigaction (sig, &(struct sigaction) { .sa_handler =3D SIG_DFL, > +=09=09=09=09=09 .sa_flags =3D 0 }, NULL); > + > { > /* Check if all signals handler are set to SIG_DFL on spawned proces= s. */ > spawn_signal_test ("SIG_DFL", NULL); Finally found out what's causing my failure: running the test suite with =E2=80=9Cnohup=E2=80=9D. Maybe you could mention this in the comment? Any= way, the patch is fixing things. I suspect H.J. is doing the same. 8-) Tested-by: Florian Weimer Reviewed-by: Florian Weimer Thanks, Florian